(feature) persistent history of search queries about astroid HOT 8 CLOSED

Absolutely! If you feel adventurous, I'd be happy to receive a pull-request 🍻 .

from astroid.

from astroid.

Ok, I appreciate the suggestions, debugging and wikiing. Hopefully,
there won't be any license issues :)

I realize c++ is not easiest to help out with.

from astroid.

Where should those queries be stored? I think it's better to not touch a hand-crafted config file via code, so I would prefer e.g. a seperate simple plain text file where astroid stores those queries.
The other thing is: What actually IS history? Really everything in chronological order? Or is it OK to delete a query when you ran the same right now? (deduplication - I already had discussions about that ;)) I prefer deduplication. If it get's controversial should there be a config switch? (no deduplication; deduplication without reordering; deduplication with reordering - some more options?)

from astroid.

I was looking at notmuch-hello for the emacs interface (https://notmuchmail.org/screenshots/), we could do something similar. Save the previous searches, and allow some to be saved (at some point). I also wanted to create a screen with an overview of tags with the number of messages in them, then the saved searches could go there. Anyway, that is a little more work.

I also think it should not be in the config file, keep say the last 100 in ~/.config/astroid/last_searches (or .cache/astroid/last_searches) and then possibly the saved searches in ~/.config/astroid/saved_searches (or the config file).

The most straightforward would probably be to just put everything in there, without worrying about duplication. If we do, I would prefer de-duplication with reordering.

from astroid.

Search history implemented in #123.

from astroid.

@hugoroy In the search box you can use the up arrow to reuse recent queries. Hope this helps.

from astroid.

Indeed, this is merged now.

from astroid.