(AUR) failed to compile about astroid HOT 7 CLOSED

Would like to reproduce, but I even don't get that far.
It already hangs at compiling the first test.

In file included from test/test_generic.cc:5:
test/test_common.hh:9:3: error: 'Astroid' is not a class, namespace, or enumeration
  Astroid::astroid = new Astroid::Astroid ();
  ^
test/test_common.hh:9:3: error: reference to 'Astroid' is ambiguous
  Astroid::astroid = new Astroid::Astroid ();
  ^
src/log.hh:21:11: note: candidate found by name lookup is 'Astroid'
namespace Astroid {
          ^
src/astroid.hh:14:9: note: candidate found by name lookup is 'Astroid::Astroid'
  class Astroid {
        ^
In file included from test/test_generic.cc:5:
test/test_common.hh:9:26: error: 'Astroid' is not a class, namespace, or enumeration
  Astroid::astroid = new Astroid::Astroid ();
                         ^
test/test_common.hh:9:26: error: reference to 'Astroid' is ambiguous
  Astroid::astroid = new Astroid::Astroid ();
                         ^
src/log.hh:21:11: note: candidate found by name lookup is 'Astroid'
namespace Astroid {
          ^
src/astroid.hh:14:9: note: candidate found by name lookup is 'Astroid::Astroid'
  class Astroid {
        ^
In file included from test/test_generic.cc:5:
test/test_common.hh:14:10: error: 'Astroid' is not a class, namespace, or enumeration
  delete Astroid::astroid;
         ^
test/test_common.hh:14:10: error: reference to 'Astroid' is ambiguous
  delete Astroid::astroid;
         ^
src/log.hh:21:11: note: candidate found by name lookup is 'Astroid'
namespace Astroid {
          ^
src/astroid.hh:14:9: note: candidate found by name lookup is 'Astroid::Astroid'
  class Astroid {
        ^
6 errors generated.

I can fix that by removing "using namespace Astroid" from
test/test_common.h. For the other tests, I then need to add "using
namespace Astroid", again.
But then I end up here:

test/test_non_existant_file.cc:57:9: error: reference to 'log' is ambiguous
        log << test << "trying to open deleted file." << endl;

NOTE: "using namespace" in a header file is really bad ;)
using namespace std; even more.

@gauteh would you mind if I went along and cleaned that up? I think I
also saw some unneeded includes which I could try to get then.

Excerpts from Hugo Roy's message of Januar 16, 2016 12:02 :

==> Lancement de check()...
scons: Reading SConscript files ...
building release: v0.4.r205.gcdea3bb
debug flag enabled: False
Checking for pkg-config... (cached) yes
Checking for gtkmm-3.0 >= 3.10... (cached) yes
Checking for glibmm-2.4... (cached) yes
Checking for gmime-2.6 >= 2.6.18... (cached) yes
Checking for webkitgtk-3.0... (cached) yes
Checking for libsass... (cached) yes
Checking for C library notmuch... (cached) yes
Checking for C function notmuch_database_get_revision()..(cached) yes
Checking for C++ library boost_filesystem... (cached) yes
Checking for C++ library boost_system... (cached) yes
Checking for C++ library boost_program_options... (cached) yes
writing src/build_config.hh..
scons: done reading SConscript files.
scons: Building targets ...
Running tests in test/test_theme
Running 1 test case...
info : welcome to astroid! - v0.4.r205.gcdea3bb
debug: utf8: 1, UTF-8
info : cf: loading test config.
TEST : cf: using home directory: /tmp/yaourt-tmp-hugo/aur-astroid/src/astroid/test/test_home
info : cf: test config, loading defaults.
info : date: init.
info : ac: initializing accounts..
info : ac: setup account: charlie for Charlie Root (default: 1)
info : global actions: set up.
info : poll: setting up.
debug: poll: interval: 0

[info ] (00:01:35): poll: periodic polling disabled.
[debug] (00:01:35): theme: loading..
[debug] (00:01:35): tv: testing version: 2
[debug] (00:01:35): tv: testing version: 2
[info ] (00:01:35): theme: processing: ui/thread-view.scss
unknown location(0): fatal error: in "Theme/loading_theme": memory access violation at address: 0x023ec970: no mapping at fault address
test/test_theme.cc(16): last checkpoint: "loading_theme" entry.

*** 1 failure is detected in the test module "TestTheme"
scons: *** [test/test_theme.passed] Error 1
scons: building terminated because of errors.

---

Reply to this email directly or view it on GitHub:
https://github.com/gauteh/astroid/issues/60

from astroid.

@ff2000: please!

from astroid.

Excerpts from Gaute Hope's message of Januar 16, 2016 7:44 :

@ff2000: please!

Done in #61.
Fix for this issue:

diff --git a/src/modes/thread_view/theme.cc b/src/modes/thread_view/theme.cc
index 82d449c..a8006bd 100644
--- a/src/modes/thread_view/theme.cc
+++ b/src/modes/thread_view/theme.cc
@@ -132,9 +132,10 @@ namespace Astroid {
     }

     const char * output = sass_context_get_output_string(context);
+    ustring retval(output);
     sass_delete_file_context (file_ctx);

-    return ustring (output);
+    return retval;
   }

   bool Theme::check_theme_version (bfs::path p) {

---

Reply to this email directly or view it on GitHub:
https://github.com/gauteh/astroid/issues/60#issuecomment-172165910

from astroid.

Fixed in #61.

from astroid.

@gauteh sorry, I did not add that change to the PR. Did't want to mix that in.
I am also not 100% sure if this is the right fix - don't know libsass (and BOOST_TEST). I just went where gdb told me and saw that suspicious sass_delete_file_context. I can have a closer look tomorrow, if that patch really (TM) does what we want.

from astroid.

ff2000 writes on January 16, 2016 20:17:

@gauteh sorry, I did not add that change to the PR. Did't want to mix that in.
I am also not 100% sure if this is the right fix - don't know libsass (and BOOST_TEST). I just went where gdb told me and saw that suspicious sass_delete_file_context. I can have a closer look tomorrow, if that patch really (TM) does what we want.

Oh, sure. I'll just reopen this one :) Looks like the right thing
though. Unless the delete in the test causes issues.

from astroid.

Done in #62.

The solution really was the way to go :)
https://github.com/sass/libsass/blob/master/src/sass_context.cpp#L562

from astroid.