mergeCommonModels function doesn`t merge required field about modelina HOT 8 CLOSED

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

from modelina.

add

        if(mergeFrom.required instanceof Array) {
            mergeTo.required = [...(mergeTo.required || []), ...mergeFrom.required];
        }

to line 154 in CommonModel

from modelina.

Good catch @czlowiek488! Do you want to add a PR fixing this? 🙂

from modelina.

Sorry, I don`t have time now and in nearest future. I must finish my generator ASAP.

from modelina.

@czlowiek488 I provided a fix for this bug, feel free to review it if you have the time of course!

from modelina.

🎉 This issue has been resolved in version 0.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from modelina.

@all-contributors please add @czlowiek488 for bug

from modelina.

@jonaslagoni

I've put up a pull request to add @czlowiek488! 🎉

from modelina.