Giter VIP home page Giter VIP logo

Comments (4)

atc0005 avatar atc0005 commented on June 12, 2024

Bonus (maybe a separate feature request?):

  • toggle to extend matches to powered off VMs also

    • defaults to limiting results to powered on VMs only

    • if enabling this setting, other states would be checked

      • toolsNotInstalled
      • toolsOld

Looking at the current PowerShell plugin I'm using, it assigns severity based on the type of status for each VM:

  • toolsNotInstalled
    • CRITICAL
  • toolsNotRunning
    • CRITICAL
  • toolsOld
    • WARNING
  • default, "Unknown issue with VMware Tools, flag this for research"

This should be available in the initial public release.

The more I look back at the PowerShell plugins I created the more I realize how comprehensive they are for the time I invested in them. As Taravangian would say, this was one of my good days. It will require some effort to get the plugins 1:1.

from check-vmware.

atc0005 avatar atc0005 commented on June 12, 2024

Looking at the current PowerShell plugin I'm using, it assigns severity based on the type of status for each VM:

From vim25\types\enum.go:

type VirtualMachineToolsStatus string

const (
    VirtualMachineToolsStatusToolsNotInstalled = VirtualMachineToolsStatus("toolsNotInstalled")
    VirtualMachineToolsStatusToolsNotRunning   = VirtualMachineToolsStatus("toolsNotRunning")
    VirtualMachineToolsStatusToolsOld          = VirtualMachineToolsStatus("toolsOld")
    VirtualMachineToolsStatusToolsOk           = VirtualMachineToolsStatus("toolsOk")
)

from check-vmware.

atc0005 avatar atc0005 commented on June 12, 2024

Perhaps "evaluate-rps" and 'ignore-rps" would be better flag names, terminology?

from check-vmware.

atc0005 avatar atc0005 commented on June 12, 2024

Perhaps "evaluate-rps" and 'ignore-rps" would be better flag names, terminology?

When written out as text in the results summary both seem to make sense as-is without additional explanation.

from check-vmware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.