Return defined types (Ruby objects) about telegram-bot-ruby HOT 3 CLOSED

Hey @AlexWayfer

Sounds interesting. Could you make some POC branch/PR for this? Just to play around and understand if it's convenient or not.

Another detail about I'm not sure: should I check response['ok'] or response.status == 200 is enough? Can there be a response with status 200, but without result (with error)? I haven't found any info about this in the documentation.

Docs don't mention anything about status code, so i'd not rely on it and keep using ok flag.

from telegram-bot-ruby.

Sounds interesting. Could you make some POC branch/PR for this? Just to play around and understand if it's convenient or not.

Yeah, I think about it. I don't think it'd take a lot of change lines. I'd like to do this with specs, but right now I have issues with logging into test environment…

Docs don't mention anything about status code, so i'd not rely on it and keep using ok flag.

I wouldn't like to do so: any 4xx or 5xx error can have no ok field, even not JSON. We should have a double check there, or just rely on 200 — that's my quesiton.

from telegram-bot-ruby.

Docs don't mention anything about status code, so i'd not rely on it and keep using ok flag.

I wouldn't like to do so: any 4xx or 5xx error can have no ok field, even not JSON. We should have a double check there, or just rely on 200 — that's my quesiton.

I've tested simple 400 errors — there is correct HTTP status, so I'd rely on it for now, and let's monitor. If we will catch cases with HTTP 200 and ok => false — it'd be very strange and we can investigate and fix it more proper.

from telegram-bot-ruby.