Comments (7)
Probably some fixed bug :)
from data.
The fields are strictly typed and if type is null, string
type is implied for BC.
Given this fact, the exception seems correct to me. Can we close this issue or why true
should imply null
or 1
?
from data.
Before boolean was stored as "1" (true) or null (false) if stored in string field, now it throws an exception. Shouldn't it store as before?
from data.
Wdym by store?
In php, we store it natively - true
/ false
, in database, we store it by 1
/ 0
. Everything seems to be correct to me, working and tested.
from data.
Will try to make repro code - I saved a false value to a string field, and got "must not be boolean" as an exception. However, if you save a false boolean value to a string field it should convert it to null, shouldn't it? And true should be saved as 1 in a string field.
from data.
No, it should not, it is a type error. Other people will open an issue false
is not converted to 0
... You have the rights to reopen this issue in case you have some new evidence, but the problem you reported here is known & wanted behaviour.
from data.
This then is a BC break, as it was automagically converted before, wasn't it? I like automatic type conversions, but am fine either way. And I don't care if false is converted to "0" or null in a string, all fine.
from data.
Related Issues (20)
- ContainsXxx throw Exception if stored value != null HOT 3
- atk4_money cannot be set to zero
- AggregateModel with referenced field in expression throwing error HOT 2
- Why getReference does not work on entity? HOT 1
- Migrator to set foreign keys HOT 2
- Default UserAction 'delete' should have a confirmation message HOT 4
- Model::validateEntityScope() should not fetch/compute any data HOT 2
- Subquery with LIMIT in IN clause should be supported HOT 12
- Does DSQL join support joining from subquery? HOT 1
- Fix all typos HOT 4
- Drop `Model\UserAction::$modifier` property
- Model::set should handle duplicate actual
- Model::dirty not available in Model::HOOK_AFTER_SAVE spot HOT 1
- Monitor if the latest deps are supported in develop using CI
- Bad float/integer input is silently accepted HOT 10
- Set fields to dirty when they are changed within hooks within a model HOT 3
- Narrow seed types more
- SQLite must keep AI incremented after rollback HOT 1
- How to schema->upgrade() ? HOT 3
- Honor backslash if not escaping HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data.