Giter VIP home page Giter VIP logo

Comments (6)

duxingren14 avatar duxingren14 commented on June 28, 2024

Thanks for the feedback. Based on our observation, our model peforms almost equally on small images and large images. We have to admit that given an input image and a casually-drawn mask, there are some possibilities that our method gonna fail, just as the failure examples shown in the supplementary materials. We appreciate the failure example you shared. We are working hard to improve the method further. Hopefully we will have some positive outputs in the near future.

from sample-imageinpainting-hifill.

ljjcoder avatar ljjcoder commented on June 28, 2024

@duxingren14 thanks for your reply. I further tested your algorithm on 256x256 resolution images, using some extremely thick masks, like this
input:

0input_Places365_val_00000968
yours:

Places365_val_00000968
edgeconnect:
Places365_val_00000968
We found that in this case, edgeconnect performed better. After testing 1,000 test images, the EC psnr was 22.428, and your psnr was 18.702. Whether your algorithm needs to scale the tested image to 256 size, the mask area cannot be too dense. If so, then replace the inpainting module in your algorithm with edgeconnect, and then use the super-resolution method you designed. Will you get better results.

from sample-imageinpainting-hifill.

duxingren14 avatar duxingren14 commented on June 28, 2024

@ljjcoder, really appreciate the evaluation. We will do more evaluations on EdgeConnect and definitely try what you recommended.

from sample-imageinpainting-hifill.

duxingren14 avatar duxingren14 commented on June 28, 2024

Recently I did some more tests on both models. Here are some discoveries: 1. edgeconnect generally did better in inpainting edge structures, 2. EdgeConnect did better when mask percentage is over 30%,, while HiFill is prone to suffer "gray-strip" artifacts; 3, EdgeConnect did wrose in maintaining color consistency. It genuinely a good idea to merge the two to get a better model than either of the two.

from sample-imageinpainting-hifill.

duxingren14 avatar duxingren14 commented on June 28, 2024

The color consistency issue of EdgeConnect is shown as below, which is very typical for EdgeConnect.
input ____________________________ ______________ hifill _______________ _____________________ edgeconnect
0011
0057
0251

from sample-imageinpainting-hifill.

kelisiya avatar kelisiya commented on June 28, 2024

The color consistency issue of EdgeConnect is shown as below, which is very typical for EdgeConnect.
input ____________________________ ______________ hifill _______________ _____________________ edgeconnect
0011
0057
0251

I am very interested in your work on EdgeConnect+HiFill_SR. Would you like to open source or share this merged work with me?

from sample-imageinpainting-hifill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.