Giter VIP home page Giter VIP logo

Comments (17)

m9 avatar m9 commented on June 30, 2024

Finally deployed heaven manually without using beta dashboard

from heaven.

atmos avatar atmos commented on June 30, 2024

Ugh, sorry. /cc @max

from heaven.

max avatar max commented on June 30, 2024

We're looking into it now.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

FWIW, I had the same thing happen even while including the HEROKU_API_KEY.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

It looks like we've got two issues.

  1. we've got a bug handling optional paramaters so @balbeko's failed because it was the key was missing.

  2. once you get past that, the build fails during asset precompilation.

-----> Preparing app for Rails asset pipeline
       Running: rake assets:precompile
       rake aborted!
       ArgumentError: invalid url

from heaven.

atmos avatar atmos commented on June 30, 2024

I switched the code over to use a new addon provider because it was free. I should probably run through all of this myself. I think it has a different environmental variable now.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

It looks like it was the redis URL that was failing, so if that's the one you changed, then that might be it.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

Above PR #59 solves the add-on problem for me. Took me forever to find my team ID, but once I did, I got this to work. We still are exploring the problem of optional params, so for now you'll need to include the HEROKU_API_KEY for the Heroku Button to work.

from heaven.

atmos avatar atmos commented on June 30, 2024

Does it blow up running the ruby code or fail to properly initialize the app?

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

Leaving HEROKU_API_KEY unspecified stops the Heroku Button from creating the app. It's a Heroku bug we're tracking internally. Basically, optional config vars are, in fact, required. :(

from heaven.

atmos avatar atmos commented on June 30, 2024

That makes a lot more sense. Thanks for the insight.

from heaven.

tcrayford avatar tcrayford commented on June 30, 2024

fails for me now, even with HEROKU_API_KEY filled in:

App could not be created
build failed
Configure Environment
App environment configuration failed. This can mean your app.json's project is not a valid Heroku application. Please ensure your app is deployable to Heroku and try again.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

@tcrayford We obviously provide poor visibility into errors in the build process, and we're tracking that internally as well. In the meantime, if you let us know the app name, I can try to track down what went wrong. You can open a ticket at https://help.heroku.com if you want to send details there.

Just in case this is the problem, I had the build fail when I specified the GITHUB_TEAM_ID as our team name rather than an integer.

from heaven.

tcrayford avatar tcrayford commented on June 30, 2024

ah yeah, that's it. I think this repo could use some better knowledge into how to find the github team id - it is not at all obvious what a team id is or where to acquire them

from heaven.

atmos avatar atmos commented on June 30, 2024

@tcrayford yeah, it really could. I know where to find it in the UI and it's in a data- attribute on an HTML element. Not ideal, really.

from heaven.

markpundsack avatar markpundsack commented on June 30, 2024

I believe we now properly support optional env vars and the app.json has the correct syntax, so I hope the original issue is fully resolved now. Thanks for your patience!

from heaven.

atmos avatar atmos commented on June 30, 2024

Considering this closed an opening an new issue for team id discovery. /cc #63

from heaven.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.