Grammar generator mishandles name property with embedded scopes about language-typescript HOT 10 OPEN

Any updates?

from language-typescript.

This also happens with other Typescript scopes: https://discuss.atom.io/t/cant-seem-to-style-element-based-on-cursor-scope/51526

from language-typescript.

Bump. Is anyone actually responsible for this project at the moment?

from language-typescript.

@lierdakil The team was on a bug bash and retreat last month so we are somewhat behind on triage.

from language-typescript.

The grammar comes from upstream and is supposed to work in a variety of editors - from their README;

This repository contains TmLanguage files that are consumed by TypeScript editors and plugins such as Visual Studio Code, The TypeScript Sublime Plugin, Atom TypeScript, and possibly others.

I'm not aware that any other editor can handle spaces in the names correctly besides VSCode so either that upstream repository isn't the one we all want to use after all or they need to consider not closing the issue with "works in VSCode" :(

from language-typescript.

FWIW, Sublime seems to handle it correctly:

while in Atom it's

when it should be

(I'm not familiar enough with Sublime to make any informed claims, but it seems that it just uses whitespace as a scope delimiter, so if grammar yields a scope with whitespace, Sublime just treats that as two scopes)

from language-typescript.

Might it might be easier to fix on Atom side?.. At least I believe a quick fix should amount to a single-line change (didn't look at the sources yet though, so allow for a ± couple lines). A "correct" fix might prove to be a bit more involved, but probably not drammatically so.

from language-typescript.

The problem is if I hack the grammar files here then we're effectively detached from upstream unless we keep remembering to make those changes every time we pull...

Also not sure what the right fix would actually be. Sure they've put multiple grammar scope names in a name but there isn't an Atom-compatible syntax for that so we'd just have to choose one or come up with some kind of combo name.

Open to suggestions or PRs (should probably sync upstream again before anyone bothers with that)

from language-typescript.

I was more thinking along the lines of patching first-mate to handle scopes with spaces actually.

A technically "correct" fix on the grammar side would be a scope-within-a-scope. So essentially (and forgive me if it doesn't work, it was a while since I last touched grammar)

match: '...'
name: 'meta.definition.function.ts'
captures: 0: name: 'entity.name.function.ts'

... although it isn't nestable, or at least I can't say from the top of my head how it could be.

from language-typescript.

And by "nestable" I actually meant "can handle more than two scopes". Sorry, long day.

from language-typescript.