[QUESTION] Code affecting the performance about bt HOT 2 OPEN

Hi,

1. This logic implements the bittorrent endgame mode as documented here: http://bittorrent.org/beps/bep_0003.html

I believe that this logic matches what libtorrent documents it does: https://github.com/steeve/libtorrent/blob/master/docs/settings.rst - see strict_end_game_mode.

It's puzzling to me that this reduces torrent performance. Roughly how fast are you downloading torrents (1 MB/s, 10MB/s, 100MB/s)? How many peers are you connected to? Does this affect performance only at the end of the torrent or for the whole download

2. I'm not familiar with this logic and don't have time to look into this.

from bt.

1. I didn't measure the exact speed in MB/s but testing the same file with client.startAsync(state->{...}, 5000) I see that every 5 seconds the number of downloaded pieces is increasing at double speed (like 8-9 new pieces vs. 3-4 every 5 second) after I remove that "else" block.
   Config.maxSimultaneouslyAssignedPieces was set to 1 all the time.
   Config.maxConcurrentlyActivePeerConnectionsPerTorrent was set to 50, before and after, no change.

I have no idea why it happens, seems that after "else" block deletion the pieces are distributed to more peers in parallel but I'm not sure. That's why I asked this question.

from bt.