Comments (7)
tirthbodawala
commented on May 12, 2024
@lukaszzdanikowski well it worked for me in Ubuntu, not sure why is it giving an error in Windows. Can you please share OS details as well?
from react-pwa.
lukaszzdanikowski
commented on May 12, 2024
@tirthbodawala Win10 Pro x64 v1703
from react-pwa.
tirthbodawala
commented on May 12, 2024
Thanks @lukaszzdanikowski I have mac and Ubuntu. will get access to Windows tomorrow morning IST. i.e. approx 16 hours from now. I will look into it asap. Thanks for reporting.
from react-pwa.
lukaszzdanikowski
commented on May 12, 2024
@tirthbodawala thanks, it looks like slashes in on of the plugins get interpreted, that is why the file urls is changed to: esourcesimagesmario-large.png
from react-pwa.
tirthbodawala
commented on May 12, 2024
Right. I am sure its something related to windows path problem. Getting a VM to solve the issue asap. If you find the bug please share the PR.
Thanks
from react-pwa.
lukaszzdanikowski
commented on May 12, 2024
I think that the issue is with pwa-srcset-loader. The npm version is not aligned with github repository (could you add version tags?). In the version that is published through npm the createPlaceholderRequest generates unescaped require if you add JSON.stringify there it should be ok. @tirthbodawala
from react-pwa.
tirthbodawala
commented on May 12, 2024
@lukaszzdanikowski Thank you so much for the wonderful PR in pwa-srcset-loader. I have merged it and upgraded the repo to use latest pwa-srcset-loader. Please let me know if you are still facing the issue.
Also I have added Docker support thus making it workable everywhere.
Thanks for your contribution.
from react-pwa.
Related Issues (20)
- Upgrade guide required HOT 5
- not able to start server, installation was successfull HOT 2
- npm start not working HOT 3
- npm start fails on Windows. HOT 3
- build, missing index.html HOT 1
- deployment guide on heroku HOT 1
- θΏθ‘ζ₯ι HOT 2
- React Confusion HOT 1
- 500 (Internal Server Error) HOT 5
- "npm start" is not working HOT 10
- Issue while npm start HOT 1
- reactpwa.com - host access Error 520 HOT 2
- chokidar.js 'return' outside of function HOT 2
- How To Build APK File For Android & IOS ? HOT 1
- Getting CSS problem on windows 10 OS HOT 1
- There is not sufficient document to start project HOT 3
- npm start on your homepage should be npm run dev
- npm run dev failed to start - Could not find a declaration file for module '@reactpwa/core/start HOT 1
- How can i change the html and body class and add stuff to the head element
- Documentation update. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pwa.