Continue last entry restarts the last entry about toggl-cli HOT 5 CLOSED

The semantics are that "start" starts a new entry, while "continue" continues an existing entry. I'm not sure I would want to confuse the two.

from toggl-cli.

@drobertadams indeed, I ended up taking a look at the code (as you are aware from the unrelated PRs), turns out my expectation was what the code was already doing when continue was called on a new day, so I did this, staff0rd/toggl-cli@9d8a6e9, which as you suggest is probably not what you're intending.

However, maybe staff0rd/toggl-cli@afb515c is helpful without the above? - should I create a PR for it?

from toggl-cli.

I think your last suggestion makes sense. It continues the last entry if no
parameters are given. Go ahead with the PR.

Robert

On Fri, Oct 16, 2015 at 7:21 PM Stafford Williams [email protected]
wrote:

@drobertadams https://github.com/drobertadams indeed, I ended up taking
a look at the code (as you are aware from the unrelated PRs), turns out my
expectation was what the code was already doing when continue was called
on a new day, so I did this, staff0rd/toggl-cli@9d8a6e9
staff0rd@9d8a6e9,
which as you suggest is probably not what you're intending.

However, maybe staff0rd/toggl-cli@afb515c
staff0rd@afb515c
is helpful without the above? - should I create a PR for it?

—
Reply to this email directly or view it on GitHub
#39 (comment)
.

Dr. Robert Adams
School of Computing and Information Systems
Grand Valley State University

from toggl-cli.

The toggl web UI defaults continue to creating a new entry, which is why the toggl-cli continue operation does not seem intuitive to me. The web UI has the following settings under My Profile;

• Save start and stop times (a new entry is created each time) [Default]
• Save duration only (continues on top of the existing time entry)

Setting this option to Save duration only causes the web UI to perform the continue similar to toggl-cli's continue.

Would you accept a PR where an option similar to the settings above is included in .togglrc (defaulting to your continue expectation if required) so that a user can control whether toggl-cli creates a new entry or not?

from toggl-cli.

Yes I would certainly accept that. I personally like continuing previous
entries (saving duration only), but as long as there's a flag in .togglrc,
it can certainly work both ways.

On Thu, Nov 12, 2015 at 12:09 AM Stafford Williams [email protected]
wrote:

The toggl web UI defaults continue to creating a new entry, which is why
the toggl-cli continue operation does not seem intuitive to me. The web
UI has the following settings under My Profile;

• Save start and stop times (a new entry is created each time)
  [Default]
• Save duration only (continues on top of the existing time entry)

Setting this option to Save duration only causes the web UI to perform
the continue similar to toggl-cli's continue.

Would you accept a PR where an option similar to the settings above is
included in .togglrc (defaulting to your continue expectation if
required) so that a user can control whether toggl-cli creates a new entry
or not?

—
Reply to this email directly or view it on GitHub
#39 (comment)
.

Dr. Robert Adams
School of Computing and Information Systems
Grand Valley State University

from toggl-cli.