Python 3 Support about toggl-cli HOT 8 CLOSED

c:\git\toggl-cli>python toggl.py
Traceback (most recent call last):
  File "toggl.py", line 1348, in <module>
    CLI().act()
  File "toggl.py", line 1118, in act
    Logger.info(TimeEntryList())
  File "toggl.py", line 272, in info
    print("%s%s" % (unicode(msg), unicode(end))),
NameError: name 'unicode' is not defined

Looks like this is due to f3dd093. @martinm76 do you need those unicode()s in there? They are specific to Python 2. I took a look at using six.u() as a fix but it relies on the string passed being unencoded ASCII only...

from toggl-cli.

My assumption that Python 3 was to be supported was based on the presence of six, however there are still further breaks that occur within the code against Python 3, and the current singleton pattern seems to be ignored by Python 3 with classes being instantiated every call (and therefore executing their init every call).

@drobertadams what is the expectation of Python 3 support?

from toggl-cli.

I haven't given Python 3 support any thought at all. I suppose some day the
project would have to migrate, but I'm not too interested in doing that. If
someone wants to port to Python 3, I'd be happy to help, but I can't lead
that effort.

On Wed, Nov 25, 2015 at 9:14 PM Stafford Williams [email protected]
wrote:

My assumption that Python 3 was to be supported was based on the presence
of six https://pypi.python.org/pypi/six, however there are still
further breaks that occur within the code against Python 3, and the current
singleton pattern seems to be ignored by Python 3 with classes being
instantiated every call (and therefore executing their init every call).

@drobertadams https://github.com/drobertadams what is the expectation
of Python 3 support?

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

Dr. Robert Adams
School of Computing and Information Systems
Grand Valley State University

from toggl-cli.

I am unable to lead such an effort also - this is the first time I've written any python and I don't really understand the Python 2/3 thing. Perhaps this issue should be re-opened to communicate that the work is up for grabs?

from toggl-cli.

If anyone wants to tackle Python 3 support, go ahead.

from toggl-cli.

@drobertadams what is the minimum version of python 2 expected to be supported?

from toggl-cli.

2.7 (?)

On Tue, Dec 1, 2015 at 6:31 PM Stafford Williams [email protected]
wrote:

@drobertadams https://github.com/drobertadams what is the minimum
version of python 2 expected to be supported?

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

Dr. Robert Adams
School of Computing and Information Systems
Grand Valley State University

from toggl-cli.

Implemented in #76

from toggl-cli.