Giter VIP home page Giter VIP logo

Comments (11)

omidkrad avatar omidkrad commented on July 17, 2024

This was fixed. I don't know how, maybe last commit fixed it?

from app-contacts.

omidkrad avatar omidkrad commented on July 17, 2024

Every time the build engine modifies the files under ./dest directory the app stops working. I have to do a git checkout ./dist and refresh the browser for it to work again.

from app-contacts.

omidkrad avatar omidkrad commented on July 17, 2024

I lied, it's not fixed! after installing npm and jspm, when I run git checkout ./dist the app works. After that when I modify any source file, as soon as the corresponsing .js file under dist is updated the app stops working an I get the above Error instantiating RouterView error. So I can run the app with no modifications but cannot run it even if I just save a .js file with no changes that updates the compiled code under dist.

from app-contacts.

omidkrad avatar omidkrad commented on July 17, 2024

I'm pretty stuck on this issue. Can you please help me figure this out?

Here are the repro steps:

  1. Clone the app-contacts repository.
  2. Install npm and jspm.
  3. Run gulp watch and open the app in the browser.
  4. Open src/app.js in Atom.
  5. Save the file as is (don't make any changes).

App will refresh and hang on the index.html page, and in the browser's console you get: Uncaught Error: Error instantiating RouterView. (see full error message)

The output dist/app.js file is replaced with the following:

System.register(['./web-api'], function (_export) {
  var WebAPI, _classCallCheck, _createClass, App;

  return {
    setters: [function (_webApi) {
      WebAPI = _webApi.WebAPI;
    }],
    execute: function () {
      'use strict';

      _classCallCheck = function (instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError('Cannot call a class as a function'); } };

      _createClass = (function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ('value' in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; })();

      App = (function () {
        function App(api) {
          _classCallCheck(this, App);

          this.api = api;
        }

        _createClass(App, [{
          key: 'configureRouter',
          value: function configureRouter(config, router) {
            config.title = 'Contacts';
            config.map([{ route: '', moduleId: 'no-selection', title: 'Select' }, { route: 'contacts/:id', moduleId: 'contact-detail' }]);

            this.router = router;
          }
        }], [{
          key: 'inject',
          value: [WebAPI],
          enumerable: true
        }]);

        return App;
      })();

      _export('App', App);
    }
  };
});

which is different from the original dist/app.js. Now if you do git checkout ./dist and refresh the browser, the app will run again.

from app-contacts.

EisenbergEffect avatar EisenbergEffect commented on July 17, 2024

I really apologize for this. The problem is because the code in the contacts app has been updated for a not-yet-released version of the router. That's why it works at first. The dist folder contains code built with the current versions, but when you recompile the source, you get code built with a future version. This will resolve itself on Monday when we have the new set of releases. From that point on, I will do releases of the contacts app so that you can always have a released version that works.

from app-contacts.

omidkrad avatar omidkrad commented on July 17, 2024

No worries, Rob. I'm glad the fix is coming up.

from app-contacts.

bsrdjan avatar bsrdjan commented on July 17, 2024

the same issue with just cloned and installed skeleton-navigation

from app-contacts.

EisenbergEffect avatar EisenbergEffect commented on July 17, 2024

Yes, it's the same cause. Please use a released version. We will get this fixed in the next day or two.

from app-contacts.

caperaven avatar caperaven commented on July 17, 2024

git clone https://github.com/aurelia/skeleton-navigation.git
npm install
jspm install -y

when I do this, I still get this error as described above.
I assume that using these commands does get the latest version or should I be doing something else?
I would love to get started with this, but having something that crashes from the beginning is not the best experience I have ever had.

If the above steps are right, then I will just need to wait, else if they are not please let me know what I need to change.

I believe the wait will be worth the while :)

from app-contacts.

bsrdjan avatar bsrdjan commented on July 17, 2024

please check the reply from Rob, use the released version not latest master. I tested that and solved the problem.

from app-contacts.

caperaven avatar caperaven commented on July 17, 2024

I don't really know how to do that, will have to google, that is why I asked if the steps were right. I just read the blog post so will try the jspm update and see what that does.

from app-contacts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.