Singleton change / issues about dependency-injection HOT 10 CLOSED

I'll check this out myself.

from dependency-injection.

Confirmed that placing singleton() on a view model works as expected, at least in the master.

from dependency-injection.

Do you have an example?

Placing @singleton() or @singleton(false)? because a few releases ago it was @singleton(false).

Any idea what could influence this? Because it definitely does not work in my code base on current release and I'm 100% sure it previously did.

from dependency-injection.

I am pretty sure it does not work -- or I don't understand how it's intended to work.

I have done some debugging and it seems the breaking change is here:
5e2b75b#diff-dcf9a6cedb6d0d9a360cc92ddaa1c0c2L52

Before commit #5e2b75b, the singleton createResolver used to return a root singleton when registerInChild was false and such a singleton already existed.
After the change, a new resolver is always created and returned. It is then registered at root (kinda) but that doesn't really matter... since the already existing singleton resolver at root is not returned, a new instance has to be created.

I think that's why my view are recreated every time.

from dependency-injection.

@jods4 Today will probably by a pre-beta release, perhaps is solved here

from dependency-injection.

Maybe, but doubtful as the sources I was looking at are master and they don't seem fundamentally different from what I'm running.

If there's a pre-beta release coming, I think this should be double-checked ASAP before the release because it's a major bug, that's worthy of being fixed for that release.

from dependency-injection.

There was a bug in the DI in the last released. It has been fixed. I tested this myself by simply placing @singleton() on the welcome view model in the navigation-skeleton app.

from dependency-injection.

Can you refer the fixing commit? I need to patch this today.

from dependency-injection.

ca5ccf7#diff-dcf9a6cedb6d0d9a360cc92ddaa1c0c2R94

Getting the latest master will require the latest of metadata also...but that is going to break everything else. So, just wait for a little bit. We are going to try to get a pre-beta release out today.

from dependency-injection.

I managed to patch around this bug but I had to do it a very ugly way. When I tried to apply the changes you linked above, the result was still the same (i.e. not reusing the same VM for the whole app). But maybe that was because I was missing other relevant bits.

I'll test with the new release and report if it doesn't work.

from dependency-injection.