off-by-one error leads to space at the end of every path about macdylibbundler HOT 5 CLOSED

So let's fix the hacks!

fef319a was an incorrect attempt to fix the problem now correctly fixed in this ticket in 8eb915a / 0d8c739.

None of dylibbundler will currently work with files whose names begin or end with or even contain spaces, because it doesn't properly escape file arguments anytime it runs a system command. But if all those were fixed, which I'd like to work on next, then you'd see that fef319a will be the reason why things don't work for those hypothetical files whose names end with spaces.

Implementing a test suite would be a great way to verify the program works correctly for various inputs...

from macdylibbundler.

Thanks for the patch, I've applied it

from macdylibbundler.

Thanks. Will you still revert fef319a?

from macdylibbundler.

Regarding fef319a I am unsure; it seems like it was originally committed with a specific purpose in mind, so reverting it may break that (even though I'm not sure why). Given that filenames ending with a space should be excessively rare, I would favor the status quo - after all, much of dylibbundler is slightly hackish anyway and will fall apart if you try hard enough

from macdylibbundler.

If you feel like improving the hacks, you are more than welcome! As for myself dylibbundler fills my current needs so I have no plans to do any more significant work on it. But if someone else would like to keep working on it that would be great

from macdylibbundler.