Create an alternative signed hash. about burner-wallet HOT 5 CLOSED

Blindly trusting you on a lot of these PRs on the contract!
Very thankful to have you helping out on the project.
I owe you some beers/DAI for sure.

The only reason we were passing the privateKey was to prevent frontrunning.
Just make sure that someone couldn't take all the same parameters and call the same function with more gas to capture the funds.

Thanks man!

from burner-wallet.

The actual link has 2 parts: claimId + privateKey
The destination is included and signed by the privateKey fom the link. This method has no advantage over a simple EOA. It is even more expensive and there is no need to use a Smart Contract because it is validating the signature in the SC instead of letting the blockchain to validate it.

This proposal removes the private key from the link and takes advantage of using a Smart Contract.
new link: claimId + claimHash + signature
With this method we'll be able to create a signed proof and remain as the owners of the signer key. It becomes a better way to manage keys usage.

from burner-wallet.

To prevent frontrunning we'll keep the destination in the hash.
The actual link has 2 parts: claimId + privateKey

from burner-wallet.

@austintgriffith We can close this issue. We could think about this later and analyze if there is an alternative or keep it as it is.

from burner-wallet.

thanks!

from burner-wallet.