QR Code Scanner about burner-wallet HOT 32 CLOSED

@jamesdigid the problem with forcing https is the create react app opens http by default and it's confusing to a first time issue. The library itself will work in production and will be on https so it's not concern of mine.

@johngrantuk heck yeah man. Would love to see some movement on this and try to get it as compatible with old phones as possible while still maintaining a smooth flow on new phones!

from burner-wallet.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $56,549.44 more funded OSS Work available on the Gitcoin Issue Explorer

from burner-wallet.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months, 2 weeks ago.
Please review their action plans below:

1) jamesdigid has started work.

Identify on what platform or mobile devices the camera doesn't load. Review documentation and 3rd party software used for qr code scanning. Load application on mobile device review console logs to better identify the problem.

Learn more on the Gitcoin Issue Details page.

2) johngrantuk has started work.

Working on figuring out the best way to detect an issue. Fall back to legacy scanner if detected.

Learn more on the Gitcoin Issue Details page.

from burner-wallet.

@aj07 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from burner-wallet.

@gitcoinbot on my dashboard, this issue is still pending.

from burner-wallet.

It's all yours if you can solve it! Please try to close it if you can. Contact me directly if you need anything. @austingriffith on twitter/telegram

from burner-wallet.

Is this issue still open? I tested the QR scanner on both Firefox, and Chrome browsers without any issues?

from burner-wallet.

It is still a problem. It's one of our biggest and I think I need to add funds to it.

We need the scanner working on every phone. Try it out on some other browsers on your phone and see how it works.

from burner-wallet.

Hello,

Is this issue still open? Are funds on gitcoin still available? One think worth mentioning is that QrCode Scanners wouldn't work on IOS 11 on any other browser but safari. That is bcs Apple has limited API support for 3rd party browsers starting with IOS 11+. I can try to dive in and have a look tho.

from burner-wallet.

WTF Apple!?! Okay so maybe let's focus on older devices and android etc. IOS chrome was my target but if there isn't anyway to do it, there's no reason to even try. Does anyone have any devices where the scanner isn't working? This might be a non-issue because of Apple.

from burner-wallet.

Yes, the scanner wasn't working on iOS 12.1 (Safari), but I've resolved it for both my phone and for chrome on MacOSX 10.13.6 (High Sierra) will push the fix up shortly.

from burner-wallet.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by:

1. @jamesdigid

@austintgriffith please take a look at the submitted work:

• PR by @jamesdigid

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $43,315.00 more funded OSS Work available on the Gitcoin Issue Explorer

from burner-wallet.

Is this finished? Does someone have a phone the scanner doesn't work on?

Sounds like iOS chrome/firefox are out. What about android chrome/firefox?

from burner-wallet.

@austintgriffith Dynamic Web TWAIN and scanner.js works fine. What's your opinion on this.

from burner-wallet.

I haven't used them. You think they would be better than the current implementation?

from burner-wallet.

The current qr code reader you have has a legacy mode which allows still images to be used, you could just add some logic to determine the user agent and browser that should work for most of your edge cases.

This was my first task on gitcoin, but are you able to fund the task?

from burner-wallet.

Yeah there is $50 USD up for anyone can that can make the thing work on as many phones as possible. Adjusting it for legacy mode when needed would be awesome! Please Do!

This piece ended up breaking some things for local development so I had to pull it:
-e "HTTPS=true"

It caused:

🗜️ Clevis:/dapp 🗜️ curl localhost:3000                                                                                          
curl: (52) Empty reply from server  

I get that we could just point to https://localhost:3000 but it was confusing to other first time devs when Create React App would come up broken.

from burner-wallet.

This task is the next big hurdle. Right now the Burner Wallet just shows a white screen when trying to scan with older iPads etc. I would love to know if anyone is trying to figure this out?

Like @jamesdigid said, if we use react-qr-scanner instead of react-qr-reader, and then detect older browsers and default over to "Legacy Mode" then we can at least have old devices take a picture of the QR code for scanning.

If no one attacks this soon, I'll jump on and try to figure it out. This one is big! Thanks guys!

from burner-wallet.

I'm happy to dig in if no one else is. I'll start looking into it properly tomorrow unless someone lets me know they're on it.

from burner-wallet.

curl: (52) Empty reply from server

"curl -k https://localhost:3000"

Should fix the empty reply from server issue. Serving over https should fix your issues with iOS and Mac OSX support. I imagine android as well, but haven't tested directly. I would pay down some technical debt before moving forward though, imo

from burner-wallet.

I’ve started taking a look at this. The general advice seems to be not to use ‘browser sniffing’ as most of the browsers give false information. Instead it’s advised to use feature detecting instead.

The QrReader has an onError event so I think it might be possible to use that to default to the legacy mode. The code for that is implemented and appears to be working.

I don’t have an iPhone or an older device to test on but I have forced an error by checking without https on my phone and also by blocking access to camera on my Mac and the legacy seems to work nicely. I’ve got a little test app running here if some others could try it out and see if the concept works on other devices?

from burner-wallet.

Any luck on this? Thinking of digging into navigator.mediaDevices on a low level and trying to build something custom if we can't get the QRReader to work well on older devices. Please let me know what kind of progress we have on this. Thanks!

from burner-wallet.

I still think defaulting to legacy on error should work but I don't have any old devices to test on so was hoping to get some feedback on the test above from someone who does.

from burner-wallet.

Oh okay. I have plenty of old devices haha. So we need to get the code deployed to a staging environment and see how it works on old devices. I'll work on that!

from burner-wallet.

@austintgriffith if you click here on your devices that should allow you to test.

from burner-wallet.

Awesome I will test it out! Also, we now have https://s.xdai.io as our staging environment. I'll keep it up with the master branch. (It's running on dai.poa.network so it still runs on mainnet xdai so you spend real pennies to test)

from burner-wallet.

Getting blank screens on both with my old devices. I'll get them plugged and figure out the errors soon.

from burner-wallet.

Ahh that's disappointing. Sorry I thought that was it cracked.

from burner-wallet.

⚡️ A tip worth 40.00000 DAI (40.0 USD @ $1.0/DAI) has been granted to @johngrantuk for this issue from @austintgriffith. ⚡️

Nice work @johngrantuk! Your tip has automatically been deposited in the ETH address we have on file.

• $51444.37 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from burner-wallet.

⚡️ A tip worth 10.00000 DAI (10.0 USD @ $1.0/DAI) has been granted to @jamesdigid for this issue from @austintgriffith. ⚡️

Nice work @jamesdigid! Your tip has automatically been deposited in the ETH address we have on file.

• $51444.37 in Funded OSS Work Available at: https://gitcoin.co/explorer
• Incentivize contributions to your repo: Send a Tip or Fund a PR
• No Email? Get help on the Gitcoin Slack

from burner-wallet.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

• austintgriffith tipped 10.0000 DAI worth 10.0 USD to jamesdigid.
• austintgriffith tipped 40.0000 DAI worth 40.0 USD to johngrantuk.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $51,394.37 more funded OSS Work available on the Gitcoin Issue Explorer

from burner-wallet.

I think I got this working as well as I can.
It will fall back if it ever fails and you can add an image or take a picture.

from burner-wallet.