Comments (6)
KOConchobhair
commented on August 11, 2024
1
@Widcket Take a look at this code (assuming I'm tracing it thru correctly)
PasswordlessLinkTransaction goes to CredentialAuth which if oidcConformant is true, calls auth0 using the password-realm grant. if false, it uses legacy-ro grant. Neither of which make sense for a magic link with an OTP code...(or at least dont make sense anymore in 2021)
It should instead be using the passwordless OTP grant (which is what $0.passwordlessMethod = .code does)
If I compare this library to Lock.Android, you can see over there it's implemented correctly and here it seems it's just not.
from lock.swift.
Widcket
commented on August 11, 2024
1
@KOConchobhair indeed, it should be using the passwordless OTP grant. It is probably like this for legacy reasons. Will dig into this.
from lock.swift.
Widcket
commented on August 11, 2024
1
This is out now in v2.22.2.
from lock.swift.
KOConchobhair
commented on August 11, 2024
Like why is PasswordlessLinkTransaction using CredentialAuth when it could be using the following line of code (from PasswordlessInteractor.login)
request = authentication.login(email: identifier, code: passcode, ...)
from lock.swift.
Widcket
commented on August 11, 2024
Hi @KOConchobhair, have you configured Lock with OIDC Conformant mode set to true?
from lock.swift.
KOConchobhair
commented on August 11, 2024
Yes
from lock.swift.
Related Issues (20)
- Swift Package Manager support [SDK-2118] HOT 3
- Is there an option to leave option to agree to privacy policy and not terms of service? HOT 2
- iOS SDK Offline authentication with WiFi HOT 5
- Memory leaks / retain cycles HOT 1
- `closable` option has no effect on iPad HOT 1
- `onCancel` callback not triggered when dismissing LockViewController on iPad HOT 4
- iOS Swift Native Redirection from Mail to the App [Passwordless + Magic link] HOT 17
- Callback for onForgotPassword HOT 1
- Password less -Add the button to redirect to the Mail App HOT 1
- Magic Link + code facility HOT 5
- Generic error message when using api.access.deny in login action HOT 4
- Fail to compile using carthage 0.38 and Xcode 13.1 HOT 2
- Is there anyway to disable "sign up" feature? HOT 1
- New version with Auth0 2.0 dependency HOT 2
- New version with Auth0 2.0 dependency HOT 1
- Needs some enhancement with the textfield HOT 1
- Updating Auth0 Dependency to v2.0 HOT 1
- Cannot add package withouth Package.swift file HOT 2
- Xcode 14.3 and Xcode 15 compatibility HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lock.swift.