Allow logging exceptions during service instantiation about autofac.servicefabric HOT 8 CLOSED

@alexmg, @tillig - any chance of getting this merged and released ?

from autofac.servicefabric.

Hi guys. Sorry, I've been away for the past few weeks and just got back today.

I assume this is to log the exception to another logging framework in addition to any existing ETW events that SF writes.

I think I prefer the RegisterServiceFabricSupport option to avoid having repeated boilerplate code on all service registrations.

In either case there would be an assumption that the logger implementation is available at the time of service registration (unless exposed using a static API like Serilog's Log class).

from autofac.servicefabric.

Yep, I see your point @alexmg, I'm cool with RegisterServiceFabricSupport, I'll submit another PR today if you like.

from autofac.servicefabric.

That would be awesome @johnkattenhorn. And thanks @fcastellscha and @EspenG for getting this started.

The new parameter should be optional and have a descriptive name like constructorExceptionCallback to indicate its scope of use is fairly limited.

We could also consider providing an options type to the RegisterServiceFabricSupport method with a default implementation that has an empty callback for the ConstructorExceptionCallback property.

from autofac.servicefabric.

Thinking about it a little, I don't think there will be enough options to warrant a whole new options type.

from autofac.servicefabric.

I pulled in the PR from @EspenG as a starting point for this and then refactored so that the action is provided to the RegisterServiceFabricSupport instead of each individual service registration.

I also made sure that the lifetime scope is proactively disposed when a constructor exception is thrown because the interceptor won't get the chance to do it.

from autofac.servicefabric.

These changes are currently on the MyGet feed in any 2.1.0 build if you would like to test them.

https://www.myget.org/F/autofac/api/v3/index.json

from autofac.servicefabric.

I need a way to resolve my logger in the callback. The callback is specified when configuring the container builder, but before the container is built. Is it possible to replace the Action<Exception> with Action<ILifetimeScope, Exception>. I can then use the ILifetimeScope to resolve my logger.
thanks

from autofac.servicefabric.