Comments (6)
bertrandboudaud
commented on June 12, 2024
1
It seems not so i will update the test with the new values.
from smartpeak.
bertrandboudaud
commented on June 12, 2024
Seems to be introduced with this commit:
from smartpeak.
dmccloskey
commented on June 12, 2024
I took a look at the commit and I don't see anything that would affect the OpenMS methods called in the pickMS2Features method.
from smartpeak.
bertrandboudaud
commented on June 12, 2024
Sorry , It comes from this commit.
OpenMS/OpenMS#5734
from smartpeak.
dmccloskey
commented on June 12, 2024
The changes proposed in the commit are quite beneficial and solve a long standing issue with the peak picker. I would imagine it would cause some changes in the number of overall picked features as measured by our unit tests.
Do any of the other tests fail besides the "RawDataProcessor.pickMS2Features" test? Do the examples also pass?
from smartpeak.
dmccloskey
commented on June 12, 2024
Sounds good to me.
from smartpeak.
Related Issues (20)
- StoreQuantitationMethods does not raise error on info panel if it's not possible to overwrite the file
- quantitationMethods.csv is not needed if you use STORE_QUANTITATION_METHODS processor HOT 1
- Calibration curve display produces flooding log HOT 1
- Running wrokflow should display number of threads in the info panel
- grpc to be compiled along with the superbuild step
- Implementation of the native file system picker
- Improved workflow step display
- Use the SessionLoaderGenerator to load the data generated by SmartPeakServer
- Sessions: implementation of SavedStates
- Improving Calibrators plot HOT 1
- Providing wrong standardsConcentrations.csv does not throw any error
- Providing UTF-8 with BOM csv does not raise any error.
- Unit test fail with update from OpenMS
- Use ImPlot zooming feature HOT 3
- FeatureFiltersUtils::loadFeatureFilters does not display error in info panel
- Workflow fails if feature (output) directory does not exists
- Export of QuantitationMethods from difference SequenceSegments
- Fit calibration Cannot exclude point correctly when 2 calibration curves are displayed
- Server and Task tests fail on MacOS (only)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smartpeak.