Giter VIP home page Giter VIP logo

Comments (5)

madalinignisca avatar madalinignisca commented on July 21, 2024

works only if "matching words" is used.

from _s.

iamtakashi avatar iamtakashi commented on July 21, 2024

@16nsk If you read carefully the third step, it says you need to search it and replace with your theme name with a space before. See the raw version of README.md if you need. I see your confusion though because the leading space is removed when we see it on https://github.com/Automattic/_s/blob/master/README.md

Does anybody have a suggestion to make it clear it has a leading space?

from _s.

ashfame avatar ashfame commented on July 21, 2024

May be we should just remove manual instructions of string replacements and encourage everyone to use the generator at underscores.me only?

from _s.

ashfame avatar ashfame commented on July 21, 2024

@iamtakashi We can use <code> instead of backtick to parse &nbsp;. Check this https://github.com/ashfame/_s/blob/readme_fix/README.md

Pull request is here - #124

Let me know if you want me to rebase the branch so that it has only 1 commit in it.

from _s.

mfields avatar mfields commented on July 21, 2024

Closing this as resolved - I originally had a few things to add, but they would be better off reported as separate issues.

from _s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.