Giter VIP home page Giter VIP logo

Comments (3)

ashfame avatar ashfame commented on August 23, 2024

It gets hidden by default on smaller screens and becomes visible when menu text is clicked. This JS file is in action here - https://github.com/Automattic/_s/blob/master/js/small-menu.js

from _s.

mppm avatar mppm commented on August 23, 2024

Thanks Ashfame!

Now I see the problem. I changed the h1 headline ( In the header.php) to an h2 since I wanted only one h1 for better structure. But obviously the JS needed the h1 to work properly, because no "menu" became visible until I changed it back to a h1 headline again.

May I suggest it would be pretty useful, if the h1 tag actually is really a link and not just a headline. Admittedly I don't know if mobile users with a visual impairment and therefore using a screenreader can identify the h1 as a link?

Best regards.

from _s.

mfields avatar mfields commented on August 23, 2024

I think that changing the h1 tag to an anchor would be inappropriate. In HTML 5 the nav element represents sectioning content and should contain heading content like an h1 tag.

Reference:

I'm going to close this ticket as wontfix Please see the following conversation for a few more reasons why: #66 (comment)

from _s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.