Comments (3)
It gets hidden by default on smaller screens and becomes visible when menu
text is clicked. This JS file is in action here - https://github.com/Automattic/_s/blob/master/js/small-menu.js
from _s.
Thanks Ashfame!
Now I see the problem. I changed the h1 headline ( In the header.php) to an h2 since I wanted only one h1 for better structure. But obviously the JS needed the h1 to work properly, because no "menu" became visible until I changed it back to a h1 headline again.
May I suggest it would be pretty useful, if the h1 tag actually is really a link and not just a headline. Admittedly I don't know if mobile users with a visual impairment and therefore using a screenreader can identify the h1 as a link?
Best regards.
from _s.
I think that changing the h1 tag to an anchor would be inappropriate. In HTML 5 the nav
element represents sectioning content and should contain heading content like an h1
tag.
Reference:
- http://www.w3.org/TR/html5/content-models.html#sectioning-content-0
- http://www.w3.org/TR/html5/headings-and-sections.html#headings-and-sections
I'm going to close this ticket as wontfix Please see the following conversation for a few more reasons why: #66 (comment)
from _s.
Related Issues (20)
- Right Sidebar Position
- Thumbnail not rendering HOT 1
- please add tailwind inside saas HOT 2
- Changing Page Title Tags from H2 to H1 - Please Help!
- the_content doesn't work for displaying single posts
- Help ME PLEASE! HOT 17
- Parent Link not clickable to the link in HOT 1
- Deprecated npm packages HOT 4
- creating unnecessary paddings with Elementor
- Custom Fonts Not Loading Safari Browser
- PHPCS not using version number specified by testVersion
- mixin for column-width deprecated in SASS 2.0
- Gutenberg Editor CSS Problems HOT 1
- Fatal error: Uncaught Error: Attempt to assign property "transport" with PHP 8.1.9
- Is this theme dead, Can I still use it as starter template? HOT 1
- Updating sass complier HOT 2
- composer make-pot fails on mac when site path contains a space
- is this nice project DEAD? HOT 3
- Theme is broken with Woocommerce
- This Project really need a serious update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from _s.