Ensure mongodb uri for replica sets work about monk HOT 7 CLOSED

No, replicasets with the mongodb:// prefix do not work. Auth details also don't work in replicaset urls, with or without the mongodb:// prefix. I'm looking at that now.

from monk.

derp, could use this as well

from monk.

#58 (comment)

from monk.

I'm in the process of adding connection error checking (#24). When I do so I notice that the replicaset connection tests fail with error Error: Could not locate any valid servers in initial seed list. Both array and string versions fail.

Looking at Mongoskin's README it looks like you actually have to use the native lib's objects when defining a replica set:

var Server = mongo.Server;
var Db = mongo.Db;

var replSet = new ReplSetServers([
        new Server('localhost', 30000),
        new Server('localhost', 30001),
        new Server('localhost', 30002),
]);

var db = new Db('integration_test_', replSet, {w:0, native_parser: (process.env['TEST_NATIVE'] != null)});

Do we need to update monk with this then?

from monk.

Actually that is't the problem - it works with a real replica set. The test fails because the servers specified in the test code aren't setup for replication.

from monk.

Another point I've realised is that a lot of the tests don't explicitly close db connections once done. And this also makes me wonder why connecting to a db isn't made to return a promise. Wouldn't it be nice to have that work the same as the rest of monk?

from monk.

Agreed

On Tue Jan 06 2015 at 1:49:14 AM Ramesh Nair [email protected]
wrote:

Another point I've realised is that a lot of the tests don't explicitly
close db connections once done. And this also makes me wonder why
connecting to a db isn't made to return a promise. Wouldn't it be nice to
have that work the same as the rest of monk?

—
Reply to this email directly or view it on GitHub
#19 (comment).

from monk.