Giter VIP home page Giter VIP logo

Comments (3)

eddiebergman avatar eddiebergman commented on August 16, 2024

Hmmm, while in principal I agree, it opens the door for what is close, i.e. should all Float parameters then also accept a tolerance?

from configspace.

nabenabe0928 avatar nabenabe0928 commented on August 16, 2024

In my use case, i.e. YAHPO, I just use the np.isclose with the default tolerance and if it's slightly out of the range, I clip the value.
Ofc, you cannot easily define what "close" means, but some packages seem to be affected by sampling from boundaries.
In that sense, all float parameters need to be (somehow) modified (optionally with warning).

from configspace.

eddiebergman avatar eddiebergman commented on August 16, 2024

Just revisited this after finisihng #346. I think there's too many places where this isclose check would introduce difficulties in value space. However we do make use of isclose in vectorized space.

I'll close this with the statement that numbers provided in value space (as opposed to vectorized space) are given by the user and as such have the ability to choose their tolerance and what they'd like to do. However if you encounter issues like this in vectorized space, then please do raise another issue!

from configspace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.