error should be set when server response with an error about use-http HOT 13 CLOSED

Okay, I'll make it so if !response.ok then set an error.

from use-http.

I will try to fix this today.

from use-http.

Yes, you can do for the time being until I get the tests up for this.

const { loading, error, data, response } = useFetch(`${BASE_URL}/${uuid}`, [uuid])
if (!response.ok) {
  // the request didn't succeed with a status code < 300
}

Apologies this is taking so long. Juggling a lot of work right now.

Side note, you can set that BASE_URL in the <Provider url={BASE_URL}><RestOfApp /></Provider>
and do useFetch({ path: `/${uuid}` }, [uuid])

from use-http.

Okay everyone, this should be fixed in v0.2.6. I'm going to close this, but do comment back on here if something is not working and I'll reopen the issue!

const { error } = useFetch('https://example.com/todos', [])
console.log('Error Name: ', error.name) // ex: 401
console.log('Error Message: ', error.message) // ex: Unauthorized

from use-http.

What is the error to be? What if it's just an error code?

from use-http.

response.status === 404
are we to say
error === 'Not Found'?

from use-http.

English is not my native language so having to compare strings feels weird to me. I would say error === 404 but I don't know how other libs does that.
Maybe message === Not Found but allow access to the full response somehow?

from use-http.

Currently, is there any way to handle a 404 apart from implementing "manual" handling?

const { loading, error, data } = useFetch(`${BASE_URL}/${uuid}`, [uuid]);
// the above is a 404 but error is undefined

Thanks

from use-http.

It's implemented and works, but I need to make tests first. You can see the PR here

from use-http.

Currently, is there any way to handle a 404 apart from implementing "manual" handling?

const { loading, error, data } = useFetch(`${BASE_URL}/${uuid}`, [uuid]);
// the above is a 404 but error is undefined

I used version 0.2.5 and when server returns 404, I get the error:

error: TypeError: Failed to execute 'text' on 'Response': body stream is locked at _callee

from use-http.

I used version 0.2.5 and when server returns 404, I get the error:

error: TypeError: Failed to execute 'text' on 'Response': body stream is locked at _callee

This error was due to fact that my server returned text error message, not json. When the response with status 404 contains json in its body, error is undefined.

from use-http.

@alex-cory Don't stress out over it, take your time :) We all have work and personal lives to take care of! Thanks

from use-http.

Hi, @alex-cory , I still don't know how to get error when promise resolved,

  const { get, response, error } = useFetch("/xxxx") 
  useEffect(() => {
    const init = async () => {
      await get()
      if(!response.ok){
        // how to get error here?
        console.log('error ',error );
      }
    }
      init()
  }, [])

from use-http.