Giter VIP home page Giter VIP logo

Comments (3)

maxkatz6 avatar maxkatz6 commented on June 1, 2024 1

@adleywd yes, there are plans to add VirtualizedUniformGrid to ItemsControl, but not in priority right now.

from avalonia.controls.itemsrepeater.

adleywd avatar adleywd commented on June 1, 2024

So after more debugging sessions, I still could not find the issue, nor replicate it in a smaller project, but It seems to related to be using a MenuFlyout to remove items. When I try to remove a command directly from the Flyout or even invoke the code from a code behind the flyout, the bug happens. If I remove the item from any other source, another window by referring to the same RemoveCommand or even using the code behind as below, it works as expected.

While debugging I checked that could be related to the RecyclePool in ItemTemplateWrapper.cs but I'm not sure since I did not dig that much into it.

<ItemsRepeater x:Name="FavoritesItemRepeater" ItemsSource="{Binding FavoritesShows}" >
                    <ItemsRepeater.Layout>
                        <UniformGridLayout ItemsJustification="Start"
                                           ItemsStretch="Fill"
                                           MaximumRowsOrColumns="4"
                                           MinColumnSpacing="5"
                                           MinRowSpacing="2"
                                           MinItemHeight="120"
                                           MinItemWidth="500" />
                    </ItemsRepeater.Layout>
                    <ItemsRepeater.Transitions>
                    </ItemsRepeater.Transitions>
                    <ItemsRepeater.ItemTemplate>
                        <DataTemplate DataType="viewModels:TvShowViewModel">
                            <Border>
                                <Border.ContextFlyout>
                                    <MenuFlyout >
                                        <MenuItem Header="{Binding TvShow.Name, StringFormat='Open {0}'}"
                                                  Command="{Binding OpenShowDetailsCommand}">
                                            <MenuItem.Icon>
                                                <avalonia:MaterialIcon Kind="OpenInNew"
                                                                       Foreground="{DynamicResource ColorPrimary}" />
                                            </MenuItem.Icon>
                                        </MenuItem>
                                        <MenuItem Header="{Binding TvShow.Name, StringFormat='Remove {0}'}"
                                                            Command="{Binding RemoveFavoriteCommand}">
                                            <MenuItem.Icon>
                                                <avalonia:MaterialIcon Kind="Delete"
                                                                       Foreground="{DynamicResource ColorDelete}" />
                                            </MenuItem.Icon>
                                        </MenuItem>
                                    </MenuFlyout>
                                </Border.ContextFlyout>
                                <components:FavoriteTvShowCard 
                                                              PointerPressed="InputElement_OnPointerPressed"
                                                               TvShowName="{Binding TvShow.Name}"
                                                               TvShowNextEpisode="{Binding NextEpisode}" />
                            </Border>
                        </DataTemplate>
                    </ItemsRepeater.ItemTemplate>
                </ItemsRepeater>
private void InputElement_OnPointerPressed(object? sender, PointerPressedEventArgs e)
    {
        if (sender is not Control control)
        {
            return;
        }

        if (control.DataContext is TvShowViewModel tvShowViewModel)
        {
            if (e.GetCurrentPoint(sender as Control).Properties.IsLeftButtonPressed)
            {
               tvShowViewModel.RemoveFavoriteCommand.Execute(null);
            }
        }
    }

from avalonia.controls.itemsrepeater.

adleywd avatar adleywd commented on June 1, 2024

I know that ItemsRepeater will eventually be discontinued, so I tested using ItemControl and everything seems to work fine, even better than ItemsRepeater, the only thing that holds me back is the missing options that UniforGridLayout.

Are there any plans to have more options in UniformGrid or something that will eventually replace the UniformGridLayout that Item Repeaters have?

from avalonia.controls.itemsrepeater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.