Giter VIP home page Giter VIP logo

Comments (6)

jdcrensh avatar jdcrensh commented on August 23, 2024 1

You're awesome @avaragado! Updated and it's working great 👍

from riw.

avaragado avatar avaragado commented on August 23, 2024

Thanks for the report!

You're right, at the moment the code runs a babel transform explicitly using babel-plugin-react-intl. I'm not familiar with babel-plugin-react-intl-auto but it may be possible to get them to play nicely together. If I get a chance in the next couple of days I'll take a look.

from riw.

jdcrensh avatar jdcrensh commented on August 23, 2024

I was able to add babel-plugin-react-intl-auto to riw without breaking any tests (it has to be run before babel-plugin-react-intl) since it's compatible with the standard defineMessages syntax. However, making the plugin user-configurable through riw.config.js was a little beyond me, since the Config object isn't passed to that function.

from riw.

avaragado avatar avaragado commented on August 23, 2024

Good to know it works! Would you be happy with a riw config setting that defines any extra plugins to run? I'm pretty sure that's doable, once I get my head back into the code.

from riw.

jdcrensh avatar jdcrensh commented on August 23, 2024

Ideally, it'd be preferable if the plugin was blackboxed just as babel-plugin-react-intl is, since there'd be no other use for it other than passing off to riw. We'd rather not have babel dependencies in our create-react-app apps 😉

Maybe it could default the config as reactIntlAuto: { removePrefix: 'src', filebase: false }, or not use the plugin if false?

from riw.

avaragado avatar avaragado commented on August 23, 2024

@jdcrensh Released in 0.7.0.

from riw.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.