Giter VIP home page Giter VIP logo

Comments (14)

avi12 avatar avi12 commented on July 18, 2024 1

I'm pretty sure that the bug is in

youtube-auto-hd/src/contents/content-script-init-desktop.ts

Lines 113 to 117 in 5d035ac

const elVideo = getVisibleElement<HTMLVideoElement>(SELECTORS.video);
const elLogo = getVisibleElement(SELECTORS.logo);
if (!elVideo || !elLogo) {
return;
}

i.e. I force check for whether a logo has loaded there even though it will never load in an embedded video

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024 1

Thanks @avi12. If you make a test(unpacked) build i can test it on my end.

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024 1

The only additional thing I need to check is for #99

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024 1

Since I had already pushed #105, it will take a little longer for #106 to go through

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024 1

Since I had already pushed #105, it will take a little longer for #106 to go through

I have a working extension so i can wait.No problems here and thanks again 👍

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024 1

Update 1.7.16 is nove live

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024 1

Thanks for the heads up @avi12 👍 Already updated,works like charm 🚀

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024

chrome-mv3-prod.zip

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024

Ok,stand by for results.Also if you know any other websites with embeded YT videos would be helpfull 👍

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024

I'm pretty sure I also have to deal with

youtube-auto-hd/src/cs-helpers/desktop/content-script-desktop.ts

Line 56 in acb6f49

const isPremiumAccount = Boolean(getVisibleElement(SELECTORS.logo).querySelector(SELECTORS.logoPremium));

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024

No change,unfortunatelly 😞

from youtube-auto-hd.

avi12 avatar avi12 commented on July 18, 2024

chrome-mv3-prod.zip

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024

Alright...back in business 👍
Again,to make sure it's working,if you know couple more websites with embeded videos,post them here please.

from youtube-auto-hd.

dnmTX avatar dnmTX commented on July 18, 2024

Ok,i got it,found another site and can confirm it's working as it should. Will wait for the official release so i can update the original extension.
Thanks again @avi12 for that fast resolution.
Closing as RESOLVED 👍

P.S. Here is a another test link(if you need it):
https://www.engr.colostate.edu/~dga/youtube-embed-test-page/

from youtube-auto-hd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.