html output is invalid for some images with inline quotes about gwtwiki HOT 4 CLOSED

[deleted comment]

I have a fix working, changes to AbstractWikiModel.java only.

In appendRawWikipediaLink(), remove the line:

rawTopicName = Encoder.encodeHtml(rawTopicName);

In appendInternalImageLink(), do the encoding (close to line 396):

                                altAttribute = captionTagNode.getBodyString();
-                               imageFormat.setAlt(altAttribute);
+                imageFormat.setAlt(Encoder.encodeHtml(altAttribute));

This breaks a couple of test cases, but I believe the test cases are wrong.
WPImageFilterTest.testImage06 and WPLinkFilterTest.testLink12 both seem to
double-escape amps in their expected results.

    public void testImage06() {
        assertEquals(
                "\n"
                        + "<p><a class=\"internal\"
href=\"http://www.bliki.info/wiki/Image:Henkell-Schl%C3%B6sschen.JPG\""
                        + " title=\"Henkell-Schlösschen "der Sektkellerei"
Henkell & Söhnlein KG\">"
                        + "<img
src=\"http://www.bliki.info/wiki/Henkell-Schl%C3%B6sschen.JPG\""
                        + " alt=\"Henkell-Schlösschen "der Sektkellerei"
Henkell & Söhnlein KG\""
                        + " title=\"Henkell-Schlösschen "der Sektkellerei"
Henkell & Söhnlein KG\""
                        + " class=\"location-none type-thumb\" />\n"
                        + "</a>\n"
                        + "<div class=\"thumbcaption\"><i>Henkell-Schlösschen</i>"
                        + " "der Sektkellerei" <a
href=\"http://www.bliki.info/wiki/Henkell_%26_S%C3%B6hnlein_KG\""
                        + " title=\"Henkell & Söhnlein KG\">"
                        + "Henkell & Söhnlein KG</a></div> Wiesbaden</p>",
                wikiModel

.render("[[Image:Henkell-Schlösschen.JPG|thumb|\'\'Henkell-Schlösschen\'\' 
\"der
Sektkellerei\" [[Henkell & Söhnlein KG]]]] Wiesbaden"));
    }

    public void testLink12() {
        assertEquals(
                "\n"
                        + "<p>kellereien wie "
                        + "<a
href=\"http://www.bliki.info/wiki/Henkell_%26_S%C3%B6hnlein\""
                        + " title=\"Henkell & Söhnlein\">Henkell</a>,"
                        + " <a href=\"http://www.bliki.info/wiki/S%C3%B6hnlein\""
                        + " title=\"Söhnlein\">Söhnlein</a></p>",
                wikiModel
                        .render("kellereien wie [[Henkell & Söhnlein|Henkell]],
[[Söhnlein]]"));
        Set<String> set = wikiModel.getLinks();
        assertTrue(set.contains("Söhnlein"));
        assertTrue(set.contains("Henkell & Söhnlein"));
    }

Changed in SVN:
http://code.google.com/p/gwtwiki/source/detail?r=525