Current DAG structure critical issue about avrio-rs HOT 20 CLOSED

OR:
Rename send, receive blocks to Credit, receipt blocks (thumbs up for yes)
VOTE ONLY ONE

from avrio-rs.

I think I was already doing that 🤔

from avrio-rs.

Another thing we need to consider is who will generate the receiving blocks in the pre-PON test nets. Im thinking maybe the sender should construct it as we do not need any fullnode signatures yet anyway. The only attack vector i can see with this is the potential for someone to spam loads of really large blocks and never broadcast a receive block for it. It would fill up the mempool and cause some issues ith low ram nodes.

from avrio-rs.

Wont be an issue in the mainnet or once we have PON as the fullnodes would be making the receive block, not the sender.

from avrio-rs.

Working on this now.

from avrio-rs.

Going to rename blocks type, send and receive are clunky as a send block is not always SENDING currency per say. I believe eth had a nice article on something similar will try to find

from avrio-rs.

ah yes, credit and receipt. Let me do a vote here

from avrio-rs.

Rename send, recieve blocks to Credit, debit blocks (thumbs up for yes)

from avrio-rs.

👍

from avrio-rs.

which one? I think the receipt one is clearer

from avrio-rs.

The reciept one makes more sense to me.

from avrio-rs.

Cool, will go with that

from avrio-rs.

trying to get avrio compiled on my rpi 4 and 3. Then set up an auto recompiler so they auto recompile and run every time i commit to github. Means i can test the syncing code much quicker

from avrio-rs.

But apparently there are a huge amount of AES optimisation instruction sets not in arm7, so it takes FOREVER and keeps crashing

from avrio-rs.

oh?

from avrio-rs.

oh, not for ARM though, only x86_64

from avrio-rs.

i see

from avrio-rs.

yeh arm doesnt allow deriving integer to vector conversions

from avrio-rs.

I believe the fix-the-branch dag has a validation issue. Annoyingly as I accidentally merged it with the p2p refactor branch I haven't yet separated the two as the root cause. From what I remember it was a hash mismatch. Could be from the way receive blocks are validated or constructed. Im looking at it now

from avrio-rs.

Believed to be resolved, need to write unit tests to confirm.

from avrio-rs.