code in application/config not being used about awesome-panel HOT 4 CLOSED

I love this push to get the repository cleaned up and would love a PR.

from awesome-panel.

Additionally any comments on what makes the repository useful (keep) and what does not (change) would be really, really valuable.

The intention is that this repo should be a valuable resource for inspiration and learning.

But it's also been on a journey pushing Panel forward and trying to find best practice solutions. 👍

from awesome-panel.

One thought I had about a useful section would be to have a template for a basic project somewhere. Like just the site getting initialized, with a dummy author, and a page or two. It was a lot to look at with the whole repo. Though if all the unnecessary stuff is removed, maybe it will be fine as it is.

I also think that at least of some of the stuff that is in _site.py when you subclass _site.Site could potentially go directly into _site.Site making it easier to use.

For example in AwesomePanelSite.create_application

...
if "thumbnail" in params:
    params["thumbnail"] = THUMBNAILS_ROOT + params["thumbnail"]
if "resources" in params:
    resources = params["resources"]
    if "code" in resources:
        resources["code"] = CODE_ROOT + resources["code"]
    if "mp4" in resources:
        resources["mp4"] = MP4_ROOT + resources["mp4"]
    if "gif" in resources:
        resources["gif"] = GIF_ROOT + resources["gif"]
return super().create_application(**params)

You could work work that into _site.Site such that it takes certain input parameters that tells it which params to append certain roots to. something like {"thumbnail": THUMBNAILS_ROOT}, and then just evaluate and whatever ones were passed in. For the ones that are keys of a dictionary in params (i.e. resources), maybe something like the {("resources", "code"): CODE_ROOT} That feels bad. I don't like that, But I am just trying to think of a way to not have to subclass _site.Site if not needed.

from awesome-panel.

Hi @madeline-scyphers

I will close this one as I believe the initial problem code in application/config has been solved.

I would be helpful if you could move your suggestions above into new, specific feature requests. Thanks.

I have opened the following requests

• #51
• #52
• #53
• #54
• #55
• #56
• #57
• #58

from awesome-panel.