Regression: dialogs are not handled correctly anymore about awesome HOT 5 CLOSED

I noticed that too

Off topic: Should we use this bug tracker or only the other one

from awesome.

Off topic: Should we use this bug tracker or only the other one

I find this one a lot friendlier, but there was the issue about vendor lock-in raised, which is a fair point. Also the other might have features that Github does not provide.

For this issue I've thought it's fine here, since it's nearer at the code itself - given that the integration of commits in the Flyspray isn't so good.

from awesome.

Nope. It's the property::screen change. During manage, property gets emitted before the geometry is set up (so that any geometry-messing done by the screen signal gets fixed up again). After the above change, this causes the client to get tagged and thus the layout code runs. Since we didn't evaluate _NET_WM_WINDOW_TYPE yet, the client isn't marked as a dialog yet and thus doesn't get floated...

So.... just revert the change to awful.tag from the above commit? (Luckily this change isn't in the 3.5 branch and doesn't block a release)

from awesome.

@psychon

So.... just revert the change to awful.tag from the above commit?

Sounds good.

from awesome.

I have found a good reason not to use the GitHub issue tracker:

This is now a duplicate of https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1238

from awesome.