Comments (11)
Malax
commented on June 24, 2024
10
In case anyone has the same problem and is looking for a solution: https://github.com/docker/login-action can be used to login into public ECR.
from amazon-ecr-login.
gmeligio
commented on June 24, 2024
6
It would be great if this action supports both private and public repositories. The name is intuitive, and developers have already tried to use it for both cases. One similar action that supports different types of repositories is docker/build-push-action and it's a great experience. Thank you for your work!
from amazon-ecr-login.
berviantoleo
commented on June 24, 2024
3
Hi everyone! This has been here a while, we're going to get some things done around this very soon.
Would you prefer that support for ECR Public is added to this action, or should we create a second action for ECR Public login and keep this one focused on ECR?
Thanks!
I prefer to add ECR Public in this action.
from amazon-ecr-login.
danielpacak
commented on June 24, 2024
1
IIUC there's code change required to use aws.ECRPUBLIC service to get login credentials. Anyway, I'd love to see the confirmation from maintainers how we can publish to ECR Gallery with this awesome action!
from amazon-ecr-login.
roimor
commented on June 24, 2024
1
@danielpacak @RickyCook @allisaurus
do you know if this was implemented ?
from amazon-ecr-login.
danielpacak
commented on June 24, 2024
The registries input param seems to be very confusing. Reading the code https://github.com/aws-actions/amazon-ecr-login/blob/master/action.yml#L8 it expects a comma-separated list of Account IDs. This would justify such regexp error.
from amazon-ecr-login.
fardin01
commented on June 24, 2024
In case anyone has the same problem and is looking for a solution: https://github.com/docker/login-action can be used to login into public ECR.
This action does not support IAM roles out of the box, does it?
from amazon-ecr-login.
heanzyzabala
commented on June 24, 2024
Any updates on this pls?
from amazon-ecr-login.
marcelloromani
commented on June 24, 2024
This requires a code change, this actions at the moment only supports Private ECRs
https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECRPUBLIC.html
I believe the registries parameters implicitly refers to the default (i.e. private) ECR of the specified AWS accounts.
from amazon-ecr-login.
jpdsteno
commented on June 24, 2024
Would love for this to be implemented soon. Having to use two discrete actions to login to each ECR registry (public and private) is not great.
from amazon-ecr-login.
jlbutler
commented on June 24, 2024
Hi everyone! This has been here a while, we're going to get some things done around this very soon.
Would you prefer that support for ECR Public is added to this action, or should we create a second action for ECR Public login and keep this one focused on ECR?
Thanks!
from amazon-ecr-login.
Related Issues (20)
- Cannot lookup ***.dkr.ecr.us-west-2.amazonaws.com: no such host
- Change docker_username and docker_password output variables for ECR private repositories HOT 3
- Certification on GitHub Marketplace HOT 2
- Docker Token Leaked in Debug Logs HOT 8
- Compatibility with `docker/build-push-action` HOT 1
- Make `mask-password` the Default Behaviour HOT 3
- Add option to not show a warning if mask-password is not set or false HOT 1
- GH Actions - Fix path variable for setup_go action
- ECR login does not work with long branch names
- Node16 Deprecation HOT 2
- Masking Docker Credentials in Amazon ECR Login Action HOT 4
- Release v2 to enable the documented usage to work HOT 5
- Error: getaddrinfo ENOTFOUND api.ecr-public.ap-northeast-1.amazonaws.com HOT 3
- Passing ECR credentials to another job doesn't work HOT 7
- Building image and then reusing it fails HOT 2
- Deprecating set-output commands HOT 1
- Getting a Registry alias of a public ECR repository with ${{ steps.login-ecr-public.outputs.registry }}
- Docker Login fails with V2; Move from --password to --password-stdin HOT 1
- Node 16 Deprecation Warning HOT 1
- get error with v2 login HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-ecr-login.