Giter VIP home page Giter VIP logo

Comments (5)

vdksystem avatar vdksystem commented on September 26, 2024 1

my account ID starts with 0 and in debug mode I see that 0 was removed

from amazon-ecr-login.

clareliguori avatar clareliguori commented on September 26, 2024

Interesting, I was not able to reproduce that behavior in the " Login to Amazon ECR using explicit registry ID" step here:
https://github.com/aws-actions/amazon-ecr-login/runs/453675212?check_suite_focus=true

Was there possibly extra whitespace around the registry ID in your workflow file? If you have CloudTrail turned on in your account, it would also be great to know what value the GetAuthorizationToken is actually receiving.

from amazon-ecr-login.

rbellamy avatar rbellamy commented on September 26, 2024

Good questions. There may have been a space in the ID. Also, I'm running in a self-hosted runner, and that runner is using an Instance Profile, so I'm not using the configure-aws-credentials action, therefore, am entering the registryId directly.

As for CloudTrail - the only events I see are from the successful push, which leads me to believe the action is targeting an invalid endpoint.

from amazon-ecr-login.

clareliguori avatar clareliguori commented on September 26, 2024

It looks like the Actions core library trims all inputs anyway, so I don't think an extra space would be the problem.
https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L74

It also looks like GetAuthorizationToken calls with invalid parameters don't actually get logged in CloudTrail. When I do aws ecr get-authorization-token --registry-ids 123456 --region us-west-2 manually, the call does not get logged, only successful calls.

Anyway, I added some debugging statements on the master branch to print out the actual registry IDs used in the call. In order to see them, you can set the secret ACTIONS_STEP_DEBUG to true in your repository and use aws-actions/amazon-ecr-login@master in your workflow file.

from amazon-ecr-login.

clareliguori avatar clareliguori commented on September 26, 2024

The debugging change has been deployed to the v1 tag

from amazon-ecr-login.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.