Giter VIP home page Giter VIP logo

Comments (6)

arjraman avatar arjraman commented on September 27, 2024 1

@kurtislamb so the issue is that a key (e.g. ecr_password) under the 'outputs' key doesn't populate if the value given to it is a secret, which the password outputted by the amazon-ecr-login action is while the username is not. I am currently looking for a workaround to see if it's possible.

from amazon-ecr-login.

kurtislamb avatar kurtislamb commented on September 27, 2024

As a further development we found that variabilization in the image actually causes a problem,i tested it with hardcoding the image value and the error still occurs

from amazon-ecr-login.

arjraman avatar arjraman commented on September 27, 2024

@kurtislamb under one of your workflow runs, you should see a annotation with a warning that says something like "Skip output 'ecr_password' since it may contain secret."

from amazon-ecr-login.

kylebyerly-hp avatar kylebyerly-hp commented on September 27, 2024

As a workaround, if you use

uses: aws-actions/amazon-ecr-login@89d5285760003229ee37172dfefe56519ce76107

it will use the last tag before secrets were masked in #241

from amazon-ecr-login.

arjraman avatar arjraman commented on September 27, 2024

@kurtislamb @kylebyerly-hp the change removing the 'secret' status of the Docker password was just released.

from amazon-ecr-login.

monirul avatar monirul commented on September 27, 2024

@kurtislamb, Can you pls give it a try. @arjraman recently fixed this issue issue in version 1.5.1 and it should work now.
Use the following syntax in the yaml file as it automatically picks the latest version (1.X.X)
uses: aws-actions/amazon-ecr-login@v1

from amazon-ecr-login.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.