Comments (4)
@renjinsk Thank you for reporting this issue, we will investigate on this one and get back to you.
from amazon-ecs-render-task-definition.
@renjinsk Could you please share your more information about this issue like your task def JSON and action settings that you are using while seeing the error?
It would be helpful for us to understand the issue better if we look at your configurations.
from amazon-ecs-render-task-definition.
Assuming you have the following workflow:
name: Some deployment workflow
on:
push:
branches:
- master
env:
CLUSTER_NAME: MyClusterName
ECR_REGISTRY: ecr_registry
REPO_ONE: repo_one
REPO_TWO: repo_two
IMAGE_TAG: sometag
jobs:
deploy_task:
name: Deploy The Task
runs-on: ubuntu-latest
steps:
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
with:
aws-access-key-id: <key>
aws-secret-access-key: <secret>
aws-region: <region>
- name: Login to AWS ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
- name: Download Task Definition
run: |
aws ecs describe-task-definition \
--task-definition <task-def-name> \
--query taskDefinition > task-definition.json
- name: Change image 1
uses: aws-actions/amazon-ecs-render-task-definition@v1
id: ch-task-def
with:
task-definition: task-definition.json
container-name: <container-name>
image: $ECR_REPOSITORY/$REPO_ONE:$IMAGE_TAG # This will fail with the message described in issue #49
- name: Deploy Task
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
with:
task-definition: ${{ steps.ch-task-def.outputs.task-definition }}
service: <service-name>
cluster: $CLUSTER_NAME # This will fail too with the message "Cluster must match ^[a-zA-Z0-9\-_]{1,255}$, but was $CLUSTER_NAME"
As you see in the codeblock comment, image:
will throw the message described in #49 and cluster:
the message already posed initial from me.
This happens when you use env variables
from amazon-ecs-render-task-definition.
Oh Dear, I just noticed I made the issue on the wrong repository. I'm terribly sorry! I will close and reopen in the correct one
from amazon-ecs-render-task-definition.
Related Issues (20)
- Add ability to set env vars from file or from AWS AppConfig
- dynamic image change HOT 2
- The `set-output` command is deprecated HOT 4
- Render for more than one container HOT 3
- Q: Error: Invalid task definition: Could not find container definition with matching name HOT 14
- How to create a new revision for an existing task definition? HOT 2
- Unable to use multi-line environment variables HOT 3
- Bug: Invalid task definition: Could not find container definition with matching name HOT 2
- current status HOT 3
- how to update the awslogs-group? HOT 2
- new dist creation workflow (package) failing
- ephemeralStorage value is not copied over
- Adding support for `dockerLabels` in task HOT 1
- How to pass environment variable file to the action? HOT 2
- dockers-labels not working HOT 4
- Node16 deprecation warning HOT 16
- I think `v1.3.0` not working with command starts with `NODE_ENV=` HOT 3
- The render action does not delete environment variables that are no longer passed to it HOT 1
- Need a way to remove Docker commands
- Download tags and cleanup unneeded properties from downloaded task definition
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-ecs-render-task-definition.