Giter VIP home page Giter VIP logo

Comments (15)

charles-hay avatar charles-hay commented on June 9, 2024 1

@dcoder4 so when you import GLTFLoader and OrbitControls it pulls from the CDN. Three.js doesn't like the import using a non-relative reference like ./, /, or ../ so I copied the raw code for those files from here and here put it somewhere else in the repo and referenced it as a local reference. This is definitely not the most elegant solution but it works 🤷

from amazon-sumerian-hosts.

rowedn avatar rowedn commented on June 9, 2024 1

I'm going to reopen this. I can reproduce this locally and I think this is an issue for everyone.

from amazon-sumerian-hosts.

brhook-aws avatar brhook-aws commented on June 9, 2024 1

@charles-hay yes, you can close the PR. We may use it as a reference for the change we are making. Once the issue has been resolved and pushed, we'll close out this issue. Apologies for the inconvenience.

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024 1

@rahulss14 that would make sense since the update is what broke it. Big 🧠

from amazon-sumerian-hosts.

rowedn avatar rowedn commented on June 9, 2024

Hi charles-hay,

Can you provide us with some extra information for how you're building and running the project? Specifically we'd like to know:

  • What operating system are you using?
  • What version of NodeJS are you using?
  • What commands did you run to build and serve the project?
  • What project are you building?

If you could link us to whatever code you've written in your project that would be helpful as well.

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024

I was using Github Pages to run it when I changed the imports of OrbitControls and GLTFLoader to a local reference instead of a CDN it worked

from amazon-sumerian-hosts.

dcoder4 avatar dcoder4 commented on June 9, 2024

I get this same error when running the three.js demo out-of-the-box. Why? Dont get any issues with the babylon.js version.
@charles-hay when you say you changed the imports to local reference what did you actually do to make work?

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024

@rowedn Did my suggestion not work or do you just want it fixed in the main repo?

from amazon-sumerian-hosts.

rowedn avatar rowedn commented on June 9, 2024

@charles-hay We want it fixed in the main repo. Thanks for bringing this to our attention!

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024

@rowedn I just made that PR. idk if you want to use that implementation or not. tbh it's not the best

from amazon-sumerian-hosts.

rowedn avatar rowedn commented on June 9, 2024

Looks like this was broken by a recent change to the version of three.js on the CDN: mrdoob/three.js@eadd35e#diff-4728538b2d7d2a8298b8ac8ded9eafbe6e8515961e5b339e56cd3e47d40d3b49

We're working on a fix right now.

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024

So should I close my PR? #69

from amazon-sumerian-hosts.

rahulss14 avatar rahulss14 commented on June 9, 2024

Another workaround is to change versions of threejs , GLTFLoader and OrbitControls .

from amazon-sumerian-hosts.

brhook-aws avatar brhook-aws commented on June 9, 2024

We've merged in the change for the fix on this issue, which changes the CDN to a version one that should work. Please re-open the issue if you continue to experience issues.

from amazon-sumerian-hosts.

charles-hay avatar charles-hay commented on June 9, 2024

Thanks @brhook-aws

from amazon-sumerian-hosts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.