Giter VIP home page Giter VIP logo

Comments (5)

ivan-georgiev avatar ivan-georgiev commented on August 19, 2024 1

@crus-umich this is ok from code point of view, but I believe this code is used by hosted rotation lambda functions, where I do not see option to modify ENV. Ref.: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-secretsmanager-rotationschedule-hostedrotationlambda.html

from aws-secrets-manager-rotation-lambdas.

itsuki3 avatar itsuki3 commented on August 19, 2024

Code branching based on version seems necessary.
For MySQL 5.6 (Aurora 1.x) ... 16 characters
For MySQL 5.7 (Aurora 2.x) ... 32 characters
For MySQL 8.0 (Aurora 3.x) ... 32 characters

from aws-secrets-manager-rotation-lambdas.

ivan-georgiev avatar ivan-georgiev commented on August 19, 2024

According to official version documentation Aurora 1.x is depreciated so may be branching is not needed. Source: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.VersionPolicy.html

from aws-secrets-manager-rotation-lambdas.

adrianwright avatar adrianwright commented on August 19, 2024

Given that Aurora 1.x is deprecated, would you receive a PR to check for 32 characters instead of 16, in all cases?

from aws-secrets-manager-rotation-lambdas.

crus-umich avatar crus-umich commented on August 19, 2024

Hello,
In order to maintain backward compatibility we have added a configurable environment variable named 'USERNAME_CHARACTER_LIMIT' to the lambda for MySQL alternating user rotation in this PR. It is defaulted to 16 but can be raised to 32 allowing for usernames up to 26 characters as we still reserve 6 for the '_clone' suffix.

Here's documentation on customizing your rotation function with this variable

from aws-secrets-manager-rotation-lambdas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.