Proposal: Add injector CRD about aws-app-mesh-controller-for-k8s HOT 4 OPEN

Just to make sure I follow your idea. You are saying having a component, foo, that watches different Injector custom resources in each namespace, and inject sidecars to pods in those namespaces according to the Injector spec.

To be more specific, I can have an "Envoy" Injector custom resource in namespace A, and a "CloudWatchAgent" Injector custom resource in namespace B, and foo is responsible for injecting "Envoy" to pods in namespace A and "CloudWatchAgent" to pods in namespace B.

Am I understanding it correctly?

from aws-app-mesh-controller-for-k8s.

Yes, that foo component is actually aws-app-mesh-inject. When installing the webhook, you provide some defaults like tracing enable with sampling 0.20, this applies to all namespaces. Next you create an injector custom resource in the prod namespace and set the sampling to 100. When a pod gets created inside the prod namespace, the webhook will query Kubernetes API for injector resources and since prod has one it, will set the sampling to 100.

from aws-app-mesh-controller-for-k8s.

This could solve https://github.com/aws/aws-app-mesh-inject/issues/59 by allowing users to specifying sidecar resources limits on a per namespace bases.

from aws-app-mesh-controller-for-k8s.

@cgchinmay @Y0Username Lets review this to see if this is something we should prioritize.

from aws-app-mesh-controller-for-k8s.