Comments (5)
Oops! Looks like we broke it here when we moved to a template file. We need an install step that works in the github docs as well as the AWS docs. Something like this could work:
curl https://raw.githubusercontent.com/aws/aws-app-mesh-controller-for-k8s/v0.1.2/examples/color.yaml.template | sed -e 's/${APP_NAMESPACE}/appmesh-demo/g' -e 's/${MESH_NAME}/color-mesh/g' ... | kubectl apply -f -
from aws-app-mesh-controller-for-k8s.
@nckturner I was about to propose a PR but there is also this variable :
${COLOR_GATEWAY_IMAGE}
I am curious to know why we don't host these example images on the AWS dockerhub registry ?
from aws-app-mesh-controller-for-k8s.
we don't have a good release process to keep those images up-to-date. I vote for moving this example to aws-app-mesh-examples project and inline it here https://github.com/aws/aws-app-mesh-examples/tree/master/walkthroughs/eks. That way users can try different examples with little additional effort after basic git clone
.
from aws-app-mesh-controller-for-k8s.
That's fine with me, but we'll need to duplicate it there, then update the AWS docs, then remove it from here.
from aws-app-mesh-controller-for-k8s.
@nckturner can this be resolved, given that the recommended installation is via helm-charts and then follow aws-app-mesh-examples.
from aws-app-mesh-controller-for-k8s.
Related Issues (20)
- PostStart hook fails if `envoyAdminAccessPort` is set HOT 3
- GatewayRoute Selector Inconsistent Behavior
- Virtual Node DNS service discovery is not working as expected HOT 2
- Outdated Changelog and release list
- Support for GatewayRoute target port HOT 1
- Unable to create routes for VirtualRouter with multiple listener HOT 4
- GatewayRoute Admission Webhook not in keeping with AWS API/UI: match prefix does not need to end in '/' HOT 1
- After modyifing the virtualrouter/virtualnode k8s manifest file it not update changes inPlace HOT 11
- GrpcRouteMatch port match error despite defining it HOT 6
- can't inject env var with a comma in it's value HOT 4
- 🚨 appmesh-envoy:v1.27.0.0-prod does not run HOT 2
- Override APPMESH_EGRESS_IGNORED_PORTS in injected proxyInit container HOT 4
- Does the cloudmap namespace have to match the k8s namespace? HOT 10
- No Init or Sidecar containers injected HOT 2
- cert-manager api deprecated HOT 1
- Missing documentation for that EKS VPC Endpoint is required for private cluster
- Cannot update VirtualRouter listener protocol with defined routes
- Cannot create sidecar containers
- Add new option to inject envoy container using sidecar feature provided by Kubernetes
- Unnecessry Virtual Node Updates
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-app-mesh-controller-for-k8s.