Add option to override resolve_s3 from samconfig about aws-sam-cli HOT 5 CLOSED

Thanks for opening this feature request. It looks like the inverse of the flag needs to be configured (ie. --no-resolve-s3) so that your desired behaviour is achieved. Let me raise this with the team for prioritization and to see if this aligns with what we wanted to do with this option.

In the mean time, I'm going to mark this as a good first issue for folks that wanted to contribute to this project.

from aws-sam-cli.

@lucashuy I would like to contribute this issue. I'm having doubt that new option--no-resolve-s3 will ignores resolve-s3 option if its present. for eg like this in deploy command.py file

if not no_resolve_s3 and resolve_s3: # here means resolve_s3 will be supported when no_resolve_s3 is not present
            if bool(s3_bucket):
                raise DeployResolveS3AndS3SetError()

am i right here ?

from aws-sam-cli.

Hi @nitintecg, this would actually be something that is changed in the existing click option, as opposed to a new option or flag. The click documentation for this behaviour can be found here: https://click.palletsprojects.com/en/8.1.x/options/#boolean-flags, and an example of how we do this with a different flag in our code can be found here:

Since resolve_s3 is a boolean, we can just use the same variable by updating the existing option.

from aws-sam-cli.

The place where we define our --resolve-s3 flag can be found here:

The changes here should be adding the inverse to the flag, and updating/adding any new unit tests to validate that the new inverse doesn't break anything.

Integration tests that actually deploy resources can be run too, but incurs any related AWS costs. The team can help out with running or writing these tests when you're ready for that.

from aws-sam-cli.

Patch is released in v1.119.0. Closing

from aws-sam-cli.