Giter VIP home page Giter VIP logo

Comments (8)

trevorrowe avatar trevorrowe commented on May 12, 2024

This is definitely on our todo list. I can't comment on when this will get done exactly, but it is a priority.

from aws-sdk-js.

ndemoor avatar ndemoor commented on May 12, 2024

+1

If only for the security best practices of not having keys flowing around.

from aws-sdk-js.

cjhanks avatar cjhanks commented on May 12, 2024

Is there reason to not support the AWS_CONFIG_FILE export as well?

from aws-sdk-js.

lsegal avatar lsegal commented on May 12, 2024

AWS_CONFIG_FILE is a different thing from using instance metadata, because it won't stop you from hardcoding the credentials on the machine. That said, you can always use AWS.config.loadFromPath(process.env.AWS_CONFIG_FILE) if you want this behaviour. Is AWS_CONFIG_FILE used in any other Amazon tools? If it is, it's likely that it's not in the same format as we would expect in the Node.js SDK, so supporting this out of the box might not work.

from aws-sdk-js.

cjhanks avatar cjhanks commented on May 12, 2024

It appears my terminology is wrong. I understood the features as related since there must be some hierarchy of checking for credentials, correct? Ie: Checking for IAM role, then bash export, then config file... etc. Currently I have found the aws-sdk-js to obey /only/ exports of ACCESS_KEY_ID and SECRET_ACCESS_KEY. If IAM roles were to be implemented, would it be in a different section of the code? ( config.js: 384 )

Note:
This is of consequence only because there is no afaik no standard export for region defined, however it is implementable via the CONFIG_FILE. It does not appear ruby SDK supports this feature either, so the request may not be valid.

from aws-sdk-js.

lsegal avatar lsegal commented on May 12, 2024

If IAM roles were to be implemented, would it be in a different section of the code?

No, it would be the next check in the chain after env vars. I actually just pushed the EC2 instance metadata branch, see #78. We don't check disk in the chain though, because as you pointed out, we don't use AWS_CONFIG_FILE as a standard mechanism for loading credentials. It seems that this variable is new to the AWS CLI tool, so we could add support for this, but note that it's not in a JSON format, so that might be something Node developers might not be used to.

This is of consequence only because there is no afaik no standard export for region defined,

We have AWS_REGION for a standard region, actually. You can use that.

from aws-sdk-js.

lsegal avatar lsegal commented on May 12, 2024

Roles on EC2 instances should now be transparently supported. Those interested in testing this out can pull down the master branch and give it a spin!

Note that we currently do not handle invalidation of expired credentials, we will be adding this before the next release, and we are tracking that specific feature as #80

from aws-sdk-js.

lock avatar lock commented on May 12, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

from aws-sdk-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.