Giter VIP home page Giter VIP logo

Comments (10)

mehowthe avatar mehowthe commented on August 23, 2024 6

I was facing same issue, for me this worked: #30 (comment)

So probably you can try to install driver with these values:

helm upgrade --install csi-secrets-store \
--namespace kube-system secrets-store-csi-driver/secrets-store-csi-driver \
--set grpcSupportedProviders="aws" --set syncSecret.enabled="true"

from secrets-store-csi-driver-provider-aws.

emtammaru avatar emtammaru commented on August 23, 2024 3

Thanks @shapirov103 and @mehowthe that was in fact the issue for me as well. Note, the secret only "syncs" with k8s secrets after applying the pod/deployment/etc that references it with secretKeyRef. I was confused at first why it wasn't showing up in kubectl get secrets after applying the SecretProviderClass by itself.

from secrets-store-csi-driver-provider-aws.

shapirov103 avatar shapirov103 commented on August 23, 2024 2

Same issue here, trying to use secret sync feature:

apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
  name: argo-aws-secrets
spec:
  provider: aws
  secretObjects:
    - secretName: bootstrap-repo-secret-sync
      type: Opaque
      labels:
        "argocd.argoproj.io/secret-type": "repository"
      data:
        - objectName: github-ssp-ssh   
          key: sshPrivateKey
        - objectName: github-ssp-ssh
          key: url 
  parameters:
    objects: | 
      - objectName: "github-ssp-ssh"
        objectType: "secretsmanager"

The behavior is exactly as described in the issue: env reference fails, however volume is mounted successfully when kubernetes secret is not referenced. Secret is not created.
On EKS version 1.19:
AWS provider image: public.ecr.aws/aws-secrets-manager/secrets-store-csi-driver-provider-aws:1.0.r1-10-g1942553-2021.06.04.00.07-linux-amd64
CSI Driver image: k8s.gcr.io/csi-secrets-store/driver:v0.0.23

from secrets-store-csi-driver-provider-aws.

askulkarni2 avatar askulkarni2 commented on August 23, 2024 1

Leaving syncSecret.enabled = false is considered a best practice as per the docs.

from secrets-store-csi-driver-provider-aws.

emtammaru avatar emtammaru commented on August 23, 2024

Same issue here. There appears to be an issue with SecretsManagerSync -- i.e. this test is not passing: https://github.com/aws/secrets-store-csi-driver-provider-aws/blob/main/tests/aws.bats#L136

from secrets-store-csi-driver-provider-aws.

shapirov103 avatar shapirov103 commented on August 23, 2024

@mehowthe thank you and confirmed, the issue was due to the helm chart value for sync secret was not set. Did not expect the behavior to be "opt-in", however, it is marked as optional, so works as designed.

from secrets-store-csi-driver-provider-aws.

brucedvgw avatar brucedvgw commented on August 23, 2024

Adding --set grpcSupportedProviders="aws" --set syncSecret.enabled="true" works a treat. It creates the Environment Variable.
However once the secret value is rotated in AWS Secrets Manager, only the file is updated and not the Environment value.

from secrets-store-csi-driver-provider-aws.

martinhaus avatar martinhaus commented on August 23, 2024

@askulkarni2 the docs clearly states - if you don't need it.

from secrets-store-csi-driver-provider-aws.

mkanna avatar mkanna commented on August 23, 2024

Adding --set grpcSupportedProviders="aws" --set syncSecret.enabled="true" works a treat. It creates the Environment Variable. However, once the secret value is rotated in AWS Secrets Manager, only the file is updated and not the Environment value.

Even I noticed the same behavior, I had to drop the secret object & roll restart of pods for the new value to show up as ENV. Is there any fix for this?

from secrets-store-csi-driver-provider-aws.

simonmarty avatar simonmarty commented on August 23, 2024

This is indented behavior of the Secret Store Driver, closing.

from secrets-store-csi-driver-provider-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.