Crash occurring when trying to force unwrap possible nil response header about aws-crt-swift HOT 7 CLOSED

Hi,

Thank you for reporting the issue. We are looking into it. Could you please specify the service to which the failing requests were made? Thank you.

from aws-crt-swift.

We are using amplify-swift.

Specifically calling confirmSignUp followed by signIn

from aws-crt-swift.

@Jeffrey-Chau-Leo, thank you for the update. I asked because this can only fail when the headers contain non-ASCII characters. Since there is no standardization for which encoding to use for headers, we are discussing multiple approaches.

from aws-crt-swift.

@Jeffrey-Chau-Leo Do you know of any cases where the headers for SignUp or SignIn might have non-ASCII characters, perhaps as part of a username or something similar? We are thinking about limiting it to ASCII characters only and ignoring the rest.

from aws-crt-swift.

@waahm7

Unfortunately, yes, we may have users who have non-ASCII characters in their usernames.

from aws-crt-swift.

This is fixed in https://github.com/awslabs/aws-crt-swift/releases/tag/0.23.0. We have made the following improvements:

• Fixed some bugs in our encoding/decoding logic around UTF-8. UTF-8 should now work properly.
• For encodings other than UTF-8, we now try to decode using UTF-8 instead of force decoding and replace invalid bytes with the missing byte symbol (�).

from aws-crt-swift.

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

from aws-crt-swift.