Comments (2)
Hello,
In 0.2.0 we have updated the way CloudFormation CreateChangeSet errors were handled to make it more informative when an error was to occur. In your current situation, it sounds like a Change Set is being created on the pipeline stack but is failing to create the change set due to some error occurring.
Once it failed, it was being cleaned up before you could check why the change set creation was failing. This might be due to missing the parameters in parameter store that the GitHub j2 template is expecting (auth token, web hook secret). Ensure you have created the required parameters in parameter store as outlined in the docs (also updated in 0.2.0).
I have created a CodeCommit based pipeline and then updated it to a GitHub pipeline in the current 0.2.0 release without an error occurring, I’ve also tested a failure (not adding required parameters to Parameter Store) and ensured the stack errors as intended.
There was also a small fix in 0.2.0 for the github-cloudformation.j2 template which resolves an issue with branches not triggering the webhook correctly so please try with the latest set of changes and let me know if this resolves the problem.
from aws-deployment-framework.
What you are saying makes a lot of sense @bundyfx, and with #10 it should no longer be silently failing, so this issue can be closed. Thank you for the quick response 🙌
from aws-deployment-framework.
Related Issues (20)
- AWS CodeBuild error: 'list' object has no attribute 'get'
- [Bug]: generate_params script type errors are not clear what's the issue
- [Bug]: <Error during ADF deployment cfn_custom_resource> HOT 4
- [Chore]: Upgrade GitHub CodeQL Action v2 to v3 HOT 1
- [Feat]: enable pylint on samples dir and optionally on test files
- ADF new version release HOT 4
- [Feat]: deploy multiple SCPs to a single OU or account HOT 6
- is it possibile to create another aws account using ADF HOT 2
- [Bug]: Account creation is broken since the release of lambda runtime 3.9v51 HOT 2
- [Feat]: Alerting for when AccountFileProcessorFunction fails
- StateMachine PipelineDeletionStateMachine is in failed HOT 1
- adf-bootstrap code pipeline fails in management account HOT 1
- [Bug]: installation through Makefile fails because of missing 'packaging' dependency HOT 3
- [Bug]: Terraform pipeline get accounts script error
- [Bug]: Terraform pipeline unable to upload the tf statefile
- [Bug]: Issue installing adf in new account HOT 2
- [Docs]: Document Discontinued Access to CodeCommit for New Customers and Migration Path HOT 1
- [Bug]: URGENT | ADF v4.0.0 update failed in Production HOT 5
- [Bug]: adf-account-bootstrapping SFN fails because of throtteling HOT 1
- [Docs]: Cloud9 is no longer available in newly created accounts
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-deployment-framework.