Feature request: enable tracing only when running on AWS Lambda about aws-lambda-powertools-typescript HOT 3 CLOSED

check the existence of one between AWS_LAMBDA_FUNCTION_NAME or AWS_EXECUTION_ENV environment variables

I suggest using only AWS_LAMBDA_FUNCTION_NAME because AWS_EXECUTION_ENV seems to be present in other compute engines as well: https://stackoverflow.com/a/54241697

from aws-lambda-powertools-typescript.

Thank you for pointing this out, I was not aware! ECR does support X-Ray though, so in that case, when enabled, it would find a parent segment and not throw an error; which is what we are trying to avoid with this change.

Generally speaking I find it counterintuitive to piggy-back on the AWS_LAMBDA_FUNCTION_NAME variable since we are effectively trying to distinguish whether we are running in a Lambda execution environment or Locally/CI.

I think accounting for all compute engines might be a bit out of the scope (given the tenets) but I can see it being a problem if we decide that it's important to our Customers.

Alternatively instead of checking wether the variable is set or not we could check if it has a value of one of the Lambda supported runtimes (nodejs10.x | nodejs12.x | nodejs14.x).

@saragerion what do you think?

from aws-lambda-powertools-typescript.

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

from aws-lambda-powertools-typescript.