Feature request: improve regex in stack trace parsing about aws-lambda-powertools-typescript HOT 5 CLOSED

I would like to contribute. Will submit a PR with the regex and unit tests.

from aws-lambda-powertools-typescript.

Hi @karthikeyanjp, thank you for reaching out.

I'll assign the issue to you and help merge the PR once ready.

from aws-lambda-powertools-typescript.

Referring to format of error locations as mentioned in https://nodejs.org/api/errors.html#errorstack & https://v8.dev/docs/stack-trace-api , we can support the following pattern:

1. plain-filename.js:line:column or /absolute/path/to/file.js:line:column or <transport-protocol>:///url/to/module/file.mjs:line:column wrapped in ().
2. location with multiple colon. Example at Script.runInThisContext (node:vm:130:12)
3. location from an eval statement.
   Example:

Error: unknown:
at eval (eval at <anonymous> (file:///home/foo/bar/some-file.ts:1:35), <anonymous>:1:7)
at <anonymous> (/home/foo/bar/file-that-threw-the-error.ts:52:3)

For pattern (3), the current & above proposed regex will extact eval at <anonymous> (file:///home/foo/bar/some-file.ts:1:35), <anonymous>:1) instead of /home/foo/bar/file-that-threw-the-error.ts:52: as there are two nested locations embedded within ().

I am proposing the regex /\(([^)]*?):(\d+):(\d+)\)\\?$/ . I tested and it works for all the cases.

Submitted PR #2194 .

@dreamorosi please let me know your thoughts on the new regex.

from aws-lambda-powertools-typescript.

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

from aws-lambda-powertools-typescript.

This is now released under v2.0.3 version!

from aws-lambda-powertools-typescript.