URLs in html getting encoded about aws-serverless-java-container HOT 11 CLOSED

The url there seems to be urlencoded. The framework itself does not do any url encoding, it simply returns the response body as a string: https://github.com/awslabs/aws-serverless-java-container/blob/master/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletResponseWriter.java#L42

Can you share some code on how the html is generated and returned? would be good to log some info along the way:

1. When the html is generated
2. Before the AwsProxyResponseis returned to API Gateway
3. What comes to the client

from aws-serverless-java-container.

PlaceListPage.txt

Attached the HTML page (changed extension to .txt)

I have Spring Controller bean that returns the html

`
@RequestMapping("/places")

public String places() {
      ....

      String url = "PlacesListPage"; // PlacesListPage.html is present under templates directory

      return url;

 }

`

Above controller is called through API gateway. Right now the HTML page is being displayed to client but URLs with in the page are encoded.

In another scenario I have redirection to external URL

`
@RequestMapping("/link")

public String link() {

      ....
      String url = "redirect:<external URL>"; 

      return url;

 }

`
In this case on browser i see an encrypted URL and 404 message

Hope this helps to explain the issue more clear.

from aws-serverless-java-container.

Thanks @gmaruti. Just to confirm, if you start the spring app on your local machine the url is returned correctly?

Take a look at the answer here: http://stackoverflow.com/questions/14938344/thymeleaf-construct-url-with-variable

from aws-serverless-java-container.

Yes, it does work in local...

from aws-serverless-java-container.

Is there any chance I can get access to the demo app to replicate? I cannot find a place where the framework would be urlencoding something. The only place where we url encode is in the response here: https://github.com/awslabs/aws-serverless-java-container/blob/master/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpServletResponse.java#L99

from aws-serverless-java-container.

never mind. I managed to replicate the issue. I will look into it and let you know.

from aws-serverless-java-container.

I located the issue in the LinkExpression class. When processing the link, it returns a URL encoded expression if the response is not null:

return response != null?response.encodeURL(url):url;

I'll investigate this comparing how the embedded container in spring boot behaves.

from aws-serverless-java-container.

@gmaruti I have committed a fix to the servlet-improvements branch. This fixes the issue for me. If you can, clone the branch, mvn install in local, change your pom to use 0.5-SNAPSHOT and test if this fixes the issue for you.

from aws-serverless-java-container.

Thanks, I will check and let you know...

from aws-serverless-java-container.

@sapessi I tested the code and it worked for me too!!.. Thanks for quick fix.

from aws-serverless-java-container.

Nice. I will close this and merge

from aws-serverless-java-container.