Comments (10)
sapessi
commented on September 23, 2024
Hi @dhcrees, just to confirm, you are using the serverless-java-container library right? Are you using Spring, Jersey, or Spark?
I'm just in the process of fixing #53 so I can take a look at this one too. When you run the test call from the API Gateway console with the space, what does the event look like in the logs on the right, could you paste it here?
from aws-serverless-java-container.
dhcrees
commented on September 23, 2024
Stefano,
Yes, we’re using the Serverless-Java-Container. (Jersey). Its been working great since the first release, but we’ve just noticed this happening (well its the first time we’ve put a space in to be fair). We’ve been able to use the container library with Jetty which allows us to run the framework locally, where we don’t see the error. It only seems to happen when we deploy the lambda to AWS.
… On 14 Aug 2017, at 20:57, Stefano Buliani ***@***.***> wrote:
Hi @dhcrees <https://github.com/dhcrees>, just to confirm, you are using the serverless-java-container library right? I'm just in the process of fixing #53 <#53> so I can take a look at this one too. When you run the test call from the API Gateway console with the space, what does the event look like in the logs on the right, could you paste it here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMu32qiq0lM6IednGUayNOHzim6XIpJks5sYKatgaJpZM4O20pQ>.
from aws-serverless-java-container.
sapessi
commented on September 23, 2024
Great thanks. Let me try and replicate. I'll update you here.
from aws-serverless-java-container.
dhcrees
commented on September 23, 2024
Stefano,
Can you confirm if you think the issue is likely to be the framework. I’ve opened a case with AWS earlier because I thought it was the gateway after I saw all the suggestions to use $util.urlEncode(). If it is then I can close the support ticker with AWS, not that people are taking his from different angles.
Many thanks.
… On 14 Aug 2017, at 21:07, Stefano Buliani ***@***.***> wrote:
Great thanks. Let me try and replicate. I'll update you here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMu39ZY1qc6iS_kaD2Jm86YsTQ1EQ8Eks5sYKj2gaJpZM4O20pQ>.
from aws-serverless-java-container.
sapessi
commented on September 23, 2024
Hey @dhcrees, I found the issue and fixed it. The issue is that the JerseyRequestReader creates a new URI with the raw values from API Gateway. Any unencoded query string parameter cause it to throw an exception. I have changed it to use Jersey's UriBuilder object that will apply encoding automatically. I've also added some additional logging to make this more obvious and some new unit tests.
I will commit my changes in a few minutes to the servlet-improvements branch. If you'd like to test, once I've committed the changes, you need to:
- Clone the
servlet-improvementsbranch from GitHub:
$ git clone -b servlet-improvements https://github.com/awslabs/aws-serverless-java-container.git- Use maven to install the new version in local:
$ mvn install - Update your pom.xml to use version
0.7-SNAPSHOT
from aws-serverless-java-container.
dhcrees
commented on September 23, 2024
Stefano,
Many thanks, I will try it when I get to work in the morning.
Just to be clear, I do the mvn install inside the clone of serverlet-improvement.?
Sorry I normally just let maven handle this stuff :)
… On 14 Aug 2017, at 21:30, Stefano Buliani ***@***.***> wrote:
Hey @dhcrees <https://github.com/dhcrees>, I found the issue and fixed it. The issue is that the JerseyRequestReader creates a new URI with the raw values from API Gateway <https://github.com/awslabs/aws-serverless-java-container/blob/master/aws-serverless-java-container-jersey/src/main/java/com/amazonaws/serverless/proxy/jersey/JerseyAwsProxyRequestReader.java#L85>. Any unencoded query string parameter cause it to throw an exception. I have changed it to use Jersey's UriBuilder object that will apply encoding automatically. I've also added some additional logging to make this more obvious and some new unit tests.
I will commit my changes in a few minutes to the servlet-improvements branch. If you'd like to test, once I've committed the changes, you need to:
Clone the servlet-improvements branch from GitHub:
$ git clone -b servlet-improvements https://github.com/awslabs/aws-serverless-java-container.git
Use maven to install the new version in local:
$ mvn install
Update your pom.xml to use version 0.7-SNAPSHOT
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMu38csX4YxfEyUSdy3Ll28S8Dn3xcmks5sYK5LgaJpZM4O20pQ>.
from aws-serverless-java-container.
sapessi
commented on September 23, 2024
@dhcrees Yes, clone the servlet improvements branch and run mvn install from that folder. This will install 0.7-SNAPSHOT in your local maven cache. Then you'll be able to refer to it from your other projects. Hopefully the official 0.7 will be out before the end of the month.
from aws-serverless-java-container.
dhcrees
commented on September 23, 2024
Excellent, once again thanks. Will try it first thing in the morning and get back to you
… On 14 Aug 2017, at 21:35, Stefano Buliani ***@***.***> wrote:
@dhcrees <https://github.com/dhcrees> Yes, clone the servlet improvements branch and run mvn install from that folder. This will install 0.7-SNAPSHOT in your local maven cache. Then you'll be able to refer to it from your other projects. Hopefully the official 0.7 will be out before the end of the month.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMu35bmPag5mDtZHT_o9S4uzb8zAohQks5sYK-DgaJpZM4O20pQ>.
from aws-serverless-java-container.
dhcrees
commented on September 23, 2024
Stefano,
I’ve cloned and tested the 0.7-SNAPSHOT into our project and everything is working as intended.
Many thanks
… On 14 Aug 2017, at 21:35, Stefano Buliani ***@***.***> wrote:
@dhcrees <https://github.com/dhcrees> Yes, clone the servlet improvements branch and run mvn install from that folder. This will install 0.7-SNAPSHOT in your local maven cache. Then you'll be able to refer to it from your other projects. Hopefully the official 0.7 will be out before the end of the month.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMu35bmPag5mDtZHT_o9S4uzb8zAohQks5sYK-DgaJpZM4O20pQ>.
from aws-serverless-java-container.
sapessi
commented on September 23, 2024
Thanks for testing @dhcrees, I'll close this and merge the changes into master today.
from aws-serverless-java-container.
Related Issues (20)
- Is it possible to inject custom classes into the controller
- Spring Cloud Gateway throwing "hostname can't be null" based on my request only having headers and not multi-value headers HOT 4
- ServletContext: Servlet.getServletConfig() is null HOT 1
- Cannot invoke "org.springframework.web.servlet.DispatcherServlet.getServletContext()" because "servlet" is null HOT 4
- org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: No content to map due to end-of-input HOT 1
- org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: No content to map due to end-of-input HOT 8
- Cannot deserialize value of type `java.lang.String` from Object value HOT 3
- SpringDelegatingLambdaContainerHandler unable to respond with rendered templates HOT 10
- SpringDelegatingLambdaContainerHandler does not handle Headers correctly for FunctionUrls HOT 7
- Cookies not able to be deleted by setting max-age to 0 HOT 3
- com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer HOT 2
- 2.x release HOT 1
- AwsProxyResponse class is generating response JSON which is rejected by API gateway with Malformed error HOT 3
- Moved AwsProxyRequestBuilder into test package HOT 4
- How to handle spring security with springboot serverless HOT 2
- Null Pointer While Setting Filter Post Startup Lambda Handler HOT 2
- Spring boot 3 context initialization issue when using with a servlet application having webflux dependency for web client HOT 3
- Error with version 2.0.2 when multi-value header is active in alb HOT 6
- Springboot 2 Lambda Layer Support HOT 2
- Query parameter values not URL decoded when using HTTP API V2 Gateway with a RequestStreamHandler implementation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-serverless-java-container.